Mukesh Rathor
2009-Jun-17 21:58 UTC
[Xen-devel] [PATCH] cpu_user_regs * to __smp_call_function_interrupt
Hi, Following simple and tiny patch will help prevent many un-necessary ifdef''s in kdb, if you''ll please apply. Thanks, Mukesh _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2009-Jun-18 07:34 UTC
Re: [Xen-devel] [PATCH] cpu_user_regs * to __smp_call_function_interrupt
On 17/06/2009 22:58, "Mukesh Rathor" <mukesh.rathor@oracle.com> wrote:> Following simple and tiny patch will help prevent many un-necessary ifdef''s in > kdb, if you''ll please apply.Passing a new paramter to a function which then ignores it is pointless. I''ll consider this as part of a patch that actually does something with it. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Mukesh Rathor
2009-Jun-19 01:30 UTC
Re: [Xen-devel] [PATCH] cpu_user_regs * to __smp_call_function_interrupt
Keir Fraser wrote:> On 17/06/2009 22:58, "Mukesh Rathor" <mukesh.rathor@oracle.com> wrote: > >> Following simple and tiny patch will help prevent many un-necessary ifdef''s in >> kdb, if you''ll please apply. > > Passing a new paramter to a function which then ignores it is pointless. > I''ll consider this as part of a patch that actually does something with it. > > -- KeirIt does, but in ext/debuggers.hg tree. Fine, I''ll just nag you more now to pull in the debuggers in mainline :). thanks, Mukesh _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2009-Jun-19 07:28 UTC
Re: [Xen-devel] [PATCH] cpu_user_regs * to __smp_call_function_interrupt
On 19/06/2009 02:30, "Mukesh Rathor" <mukesh.rathor@oracle.com> wrote:>> Passing a new paramter to a function which then ignores it is pointless. >> I''ll consider this as part of a patch that actually does something with it. >> >> -- Keir > > It does, but in ext/debuggers.hg tree. Fine, I''ll just nag you more now > to pull in the debuggers in mainline :).It''s like a 10-line patch. Just carry it! -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel