Xen devel - Jun 2009 - [PATCH] fix domid length in xenconsole

Hi all,
the last patch for xenconsole erroneously assumed that the max length
of a domid in char is 3 while is obviously 5; this patch fixes it.
Also snprintf includes the final ''\0'' in the char count.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

---

diff -r 33894148c1fd tools/console/client/main.c
--- a/tools/console/client/main.c	Tue Jun 16 13:42:22 2009 +0100
+++ b/tools/console/client/main.c	Tue Jun 16 13:45:18 2009 +0100
@@ -306,10 +306,10 @@
 	dom_path = xs_get_domain_path(xs, domid);
 	if (dom_path == NULL)
 		err(errno, "xs_get_domain_path()");
-	path = malloc(strlen(dom_path) + strlen("/serial/0/tty") + 3);
+	path = malloc(strlen(dom_path) + strlen("/serial/0/tty") + 5);
 	if (path == NULL)
 		err(ENOMEM, "malloc");
-	snprintf(path, strlen(dom_path) + strlen("/serial/0/tty") + 2,
"%s/serial/%d/tty", dom_path, num);
+	snprintf(path, strlen(dom_path) + strlen("/serial/0/tty") + 5,
"%s/serial/%d/tty", dom_path, num);
 
 	/* FIXME consoled currently does not assume domain-0 doesn''t have a
 	   console which is good when we break domain-0 up.  To keep us

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel