Hi, all This patch update rombios to the latest Bochs''s. I''d like to corabolate bochs community to enhance the guest bios. I''m not familiar around TCGBIOS. So could you review the patch? I tested boot/shutdown, S3 suspend/resume with linux guest. Any comments are welcome :-) Best Regards, Akio Takebe _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Stefan Berger wrote:> xen-devel-bounces@lists.xensource.com wrote on 12/17/2008 09:50:35 AM: > >> Akio Takebe <takebe_akio@jp.fujitsu.com> >> Sent by: xen-devel-bounces@lists.xensource.com >> >> Subject >> >> [Xen-devel] [Patch][RFC] Update rombios.c >> >> Hi, all >> >> This patch update rombios to the latest Bochs''s. >> I''d like to corabolate bochs community to enhance the guest bios. >> I''m not familiar around TCGBIOS. >> So could you review the patch? > > There are at least some problems now in the recent Boch''s BIOSes with code > sections filling up (spill into other functions'' code and bcc not telling > you about it) that require some rearranging of the code so that the > TCGBIOS part fits in when activated. I can fix this when your code has > been committed into the xen repository.Thank you for your kindness. Best Regards, Akio Takebe _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Akio Takebe wrote:> Hi, all > > This patch update rombios to the latest Bochs''s. > I''d like to corabolate bochs community to enhance the guest bios. > I''m not familiar around TCGBIOS. > So could you review the patch? > > I tested boot/shutdown, S3 suspend/resume with linux guest. > Any comments are welcome :-)I forgot Singed-off-by line. Signed-off-by: Akio Takebe <takebe_akio@jp.fujitsu.com> Best Regards, Akio Takebe _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Akio Takebe wrote:> Hi, all > > This patch update rombios to the latest Bochs''s. > I''d like to corabolate bochs community to enhance the guest bios. > I''m not familiar around TCGBIOS. > So could you review the patch? > > I tested boot/shutdown, S3 suspend/resume with linux guest. > Any comments are welcome :-)This attached file is diffs from the latest rombios of bochs. I hope it helps you at reviewing my patch. Best Regards, Akio Takebe _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Hi, At 23:50 +0900 on 17 Dec (1229557835), Akio Takebe wrote:> This patch update rombios to the latest Bochs''s. > I''d like to corabolate bochs community to enhance the guest bios. > I''m not familiar around TCGBIOS. > So could you review the patch? > > I tested boot/shutdown, S3 suspend/resume with linux guest. > Any comments are welcome :-)Does the boot-options menu work properly after the patch? This bit of code looks suspect to me; surely some more translation is necessary to turn a scan code into an offset into the boot device table: + while (!valid_choice) { + scan_code = get_keystroke(); + if (scan_code == 0x01 || scan_code == 0x58) /* ESC or F12 */ + { + valid_choice = 1; + } + else if (scan_code <= count) + { + valid_choice = 1; + scan_code -= 1; + /* Set user selected device */ + write_word(ebda_seg, IPL_BOOTFIRST_OFFSET, scan_code); + } + } Otherwise, this patch looks good to me, though it''s enormous so I haven''t looked at every detail. Also: does this update mean that the Xen rombios now has two separate 32-bit extensions? Might it be worth using the upstream one instead of maintaining our own? Cheers, Tim. -- Tim Deegan <Tim.Deegan@citrix.com> Principal Software Engineer, Citrix Systems (R&D) Ltd. [Company #02300071, SL9 0DZ, UK.] _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Tim Deegan wrote:> Hi, > > At 23:50 +0900 on 17 Dec (1229557835), Akio Takebe wrote: >> This patch update rombios to the latest Bochs''s. >> I''d like to corabolate bochs community to enhance the guest bios. >> I''m not familiar around TCGBIOS. >> So could you review the patch? >> >> I tested boot/shutdown, S3 suspend/resume with linux guest. >> Any comments are welcome :-) > > Does the boot-options menu work properly after the patch? This bit of > code looks suspect to me; surely some more translation is necessary to > turn a scan code into an offset into the boot device table: > > + while (!valid_choice) { > + scan_code = get_keystroke(); > + if (scan_code == 0x01 || scan_code == 0x58) /* ESC or F12 */ > + { > + valid_choice = 1; > + } > + else if (scan_code <= count) > + { > + valid_choice = 1; > + scan_code -= 1; > + /* Set user selected device */ > + write_word(ebda_seg, IPL_BOOTFIRST_OFFSET, scan_code); > + } > + } >Thank you for your review. I used the bochs upstream code instead of xen''s because I want to use the upstream code. It works fine. The scan_codes are below. http://www.arl.wustl.edu/~lockwood/class/cs306/books/artofasm/APNDXC.PDF> Otherwise, this patch looks good to me, though it''s enormous so I > haven''t looked at every detail. > > Also: does this update mean that the Xen rombios now has two separate > 32-bit extensions? Might it be worth using the upstream one instead of > maintaining our own? >I added "#define LAGACY" in rombios.h So the patch uses Xen''s 32bit extentions. As you said, using the upstream one may be better. But merging the upstream''s 32bits extentions looks difficult because xen initialize some parts of BIOS data in hvmloader. Best Regards, Akio Takebe _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
At 22:27 +0900 on 18 Dec (1229639259), Akio Takebe wrote:> It works fine. The scan_codes are below. > http://www.arl.wustl.edu/~lockwood/class/cs306/books/artofasm/APNDXC.PDFAh, I see. :)> I added "#define LAGACY" in rombios.h > So the patch uses Xen''s 32bit extentions. > As you said, using the upstream one may be better. > But merging the upstream''s 32bits extentions looks difficult > because xen initialize some parts of BIOS data in hvmloader.Sure. There''s certainly no need to do anything as part of this patch. Cheers, Tim. -- Tim Deegan <Tim.Deegan@citrix.com> Principal Software Engineer, Citrix Systems (R&D) Ltd. [Company #02300071, SL9 0DZ, UK.] _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel