Liu, Jinsong
2008-Dec-11 05:34 UTC
[Xen-devel][PATCH] Change default cpufreq governor from performance to ondemand
Change default cpufreq governor from performance to ondemand Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2008-Dec-11 11:22 UTC
Re: [Xen-devel][PATCH] Change default cpufreq governor from performance to ondemand
How significant is the performance impact likely to be? -- Keir On 11/12/2008 05:34, "Liu, Jinsong" <jinsong.liu@intel.com> wrote:> Change default cpufreq governor from performance to ondemand > > Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com>_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Liu, Jinsong
2008-Dec-11 11:52 UTC
RE: [Xen-devel][PATCH] Change default cpufreq governor from performance to ondemand
Keir Fraser wrote:> How significant is the performance impact likely to be? > > -- Keir > > On 11/12/2008 05:34, "Liu, Jinsong" <jinsong.liu@intel.com> wrote: > >> Change default cpufreq governor from performance to ondemand >> >> Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com>Keir, Sorry, I didn''t speak clear the reason why we change default cpufreq governor from ''performance'' to ''ondemand''. We send out user PM interface patch yesterday, at that time the default governor is ''performance'', which is similar to the default setting of native linux. However, since we didn''t send out xenpm tools until now, and considering people want to test ''ondemand'' governor, we temporarily set default governor as ''ondemand'', as what we did recently. After we send out xenpm tools, we will set default governor as ''performance'' again. At that time, user can use xenpm tool to change cpufreq governor to ''ondemand'' on-the-fly if he want. Thanks, Jinsong _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2008-Dec-11 12:53 UTC
Re: [Xen-devel][PATCH] Change default cpufreq governor from performance to ondemand
On 11/12/2008 11:52, "Liu, Jinsong" <jinsong.liu@intel.com> wrote:> Sorry, I didn''t speak clear the reason why we change default cpufreq governor > from ''performance'' to ''ondemand''. > We send out user PM interface patch yesterday, at that time the default > governor is ''performance'', which is similar to the default setting of native > linux. > However, since we didn''t send out xenpm tools until now, and considering > people want to test ''ondemand'' governor, we temporarily set default governor > as ''ondemand'', as what we did recently. > After we send out xenpm tools, we will set default governor as ''performance'' > again. At that time, user can use xenpm tool to change cpufreq governor to > ''ondemand'' on-the-fly if he want.Perhaps a boot-time option to set the initial default would be better? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Liu, Jinsong
2008-Dec-11 14:59 UTC
RE: [Xen-devel][PATCH] Change default cpufreq governor from performance to ondemand
Keir Fraser wrote:> On 11/12/2008 11:52, "Liu, Jinsong" <jinsong.liu@intel.com> wrote: > >> Sorry, I didn''t speak clear the reason why we change default cpufreq >> governor from ''performance'' to ''ondemand''. >> We send out user PM interface patch yesterday, at that time the >> default governor is ''performance'', which is similar to the default >> setting of native linux. However, since we didn''t send out xenpm >> tools until now, and considering people want to test ''ondemand'' >> governor, we temporarily set default governor as ''ondemand'', as what >> we did recently. >> After we send out xenpm tools, we will set default governor as >> ''performance'' again. At that time, user can use xenpm tool to change >> cpufreq governor to ''ondemand'' on-the-fly if he want. > > Perhaps a boot-time option to set the initial default would be better? > > -- KeirEn, in fact we also think this solution, let command line parse to set initial default governor. However, it also need user to set at grub, compared with xenpm, seems xenpm tool is some convenient to user, since by xenpm user can get initial default governor and change governor on the fly. It''s my draft thinking, and we can add boot-time option ASAP once you think needed. Thanks, Jinsong _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2008-Dec-11 15:10 UTC
Re: [Xen-devel][PATCH] Change default cpufreq governor from performance to ondemand
On 11/12/2008 14:59, "Liu, Jinsong" <jinsong.liu@intel.com> wrote:>> Perhaps a boot-time option to set the initial default would be better? >> >> -- Keir > > En, in fact we also think this solution, let command line parse to set initial > default governor. > However, it also need user to set at grub, compared with xenpm, seems xenpm > tool is some convenient to user, since by xenpm user can get initial default > governor and change governor on the fly. > It''s my draft thinking, and we can add boot-time option ASAP once you think > needed.Well a boot option would simply be another way to specify the initial default? I would accept a patch to do that, and I won''t accept your patch to temporarily change performance to on_demand. Or we can do nothing, if actually this isn''t very important. Up to you. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Liu, Jinsong
2008-Dec-12 01:44 UTC
RE: [Xen-devel][PATCH] Change default cpufreq governor from performance to ondemand
Keir Fraser wrote:> On 11/12/2008 14:59, "Liu, Jinsong" <jinsong.liu@intel.com> wrote: > >>> Perhaps a boot-time option to set the initial default would be >>> better? >>> >>> -- Keir >> >> En, in fact we also think this solution, let command line parse to >> set initial default governor. However, it also need user to set at >> grub, compared with xenpm, seems xenpm tool is some convenient to >> user, since by xenpm user can get initial default governor and >> change governor on the fly. >> It''s my draft thinking, and we can add boot-time option ASAP once >> you think needed. > > Well a boot option would simply be another way to specify the initial > default? I would accept a patch to do that, and I won''t accept your > patch to temporarily change performance to on_demand. Or we can do > nothing, if actually this isn''t very important. Up to you. > > -- Keir > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-develKeir, Just discuss with Kevin. Let''s do nothing, and we will send xenpm tool ASAP. Thanks, Jinsong _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel