Liu, Jinsong
2008-Dec-11 03:31 UTC
[Xen-devel][PATCH] Cancel BUILD_BUG_ON check because it has not been defined at some kernel.h version
Cancel BUILD_BUG_ON check because it has not been defined at some kernel.h version. Signed-off-by: Liu Jinsong <jinsong.liu@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Campbell
2008-Dec-11 11:23 UTC
Re: [Xen-devel][PATCH] Cancel BUILD_BUG_ON check because it has not been defined at some kernel.h version
On Thu, 2008-12-11 at 11:31 +0800, Liu, Jinsong wrote:> Cancel BUILD_BUG_ON check because it has not been defined at some kernel.h version.Using an obviously Linux kernel-ish header from userspace like that is pretty dodgy anyway and frowned upon by the kernel people. If we want that functionality in our userspace tools we should define the macro ourselves. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2008-Dec-11 11:40 UTC
Re: [Xen-devel][PATCH] Cancel BUILD_BUG_ON check because it has not been defined at some kernel.h version
On 11/12/2008 11:23, "Ian Campbell" <Ian.Campbell@citrix.com> wrote:> On Thu, 2008-12-11 at 11:31 +0800, Liu, Jinsong wrote: >> Cancel BUILD_BUG_ON check because it has not been defined at some kernel.h >> version. > > Using an obviously Linux kernel-ish header from userspace like that is > pretty dodgy anyway and frowned upon by the kernel people. > > If we want that functionality in our userspace tools we should define > the macro ourselves.I fixed these xc_pm.c issues independently already. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel