Fix one timer range issue
According to the timer sematic, the timer can be executed at any timer within
[expires, expires_end], however, current implementation only allow timer to be
executed after expires_end, which is not conform to the timer sematic. this
patch fix this issue.
This patch fix the the SPECpower score regression (~5% downgrade) introduced by
changeset 18744 "Change timer implementation to allow variable
''slop''"
Signed-off-by: Yu Ke <ke.yu@intel.com>
diff -r f12d9595d07c xen/common/timer.c
--- a/xen/common/timer.c
+++ b/xen/common/timer.c
@@ -396,7 +396,7 @@ static void timer_softirq_action(void)
/* Execute ready heap timers. */
while ( (GET_HEAP_SIZE(heap) != 0) &&
- ((t = heap[1])->expires_end < now) )
+ ((t = heap[1])->expires < now) )
{
remove_from_heap(heap, t);
t->status = TIMER_STATUS_inactive;
@@ -404,7 +404,7 @@ static void timer_softirq_action(void)
}
/* Execute ready list timers. */
- while ( ((t = ts->list) != NULL) && (t->expires_end < now)
)
+ while ( ((t = ts->list) != NULL) && (t->expires < now) )
{
ts->list = t->list_next;
t->status = TIMER_STATUS_inactive;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel