Handle dom0_max_vcpus < nr_pcpu cases, e.g. UP dom0. Just try to pass info about all acpi processors to xen even in such cases. Signed-off-by: Tian Kevin <kevin.tian@intel.com> Signed-off-by: Wei Gang <gang.wei@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jan Beulich
2008-Apr-29 06:50 UTC
RE: [Xen-devel] [PATCH 8/9] Add cpu idle pwr mgmt to xen
>>> "Wei, Gang" <gang.wei@intel.com> 29.04.08 02:50 >>> >On Monday, April 28, 2008 5:38 PM, Jan Beulich wrote: >>>>> "Wei, Gang" <gang.wei@intel.com> 25.04.08 07:09 >>> >>> Handle dom0_max_vcpus < nr_pcpu cases, e.g. UP dom0. >>> >>> Just try to pass info about all acpi processors to xen even in such >>> cases. >>> >>> Signed-off-by: Tian Kevin <kevin.tian@intel.com> >>> Signed-off-by: Wei Gang <gang.wei@intel.com> >> >> Are the changes done here native-compatible? They don''t really look >like >> they are from a brief inspection... I''d be glad to read a closer >> explanation of what is being attempted here. > >These changes should be native-compatible. We are attempting to make >ACPI info parsing work for all physical cpus even dom0 vcpu nr < phys >cpu nr. UP dom0 is a case requested by Keir for xen server probably go >in that way. Without these changes, only BSP ACPI info can be parsed and >passed to HV. Is that clear for you? Or any further comments?I understand the intention, but I''m worried about breaking native kernels: If the changes you made are appropriate for native, then why aren''t they upstream? And if they aren''t or if there is any doubt, then they ought to at least be contained in #ifdef CONFIG_XEN blocks (but of course I''d much prefer not having many of these in generic code, and even more in ACPI CA code). Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Tuesday, April 29, 2008 2:51 PM, Jan Beulich wrote:>>>> "Wei, Gang" <gang.wei@intel.com> 29.04.08 02:50 >>> >> On Monday, April 28, 2008 5:38 PM, Jan Beulich wrote: >>>>>> "Wei, Gang" <gang.wei@intel.com> 25.04.08 07:09 >>> >>>> Handle dom0_max_vcpus < nr_pcpu cases, e.g. UP dom0. >>>> >>>> Just try to pass info about all acpi processors to xen even in such >>>> cases. >>>> >>>> Signed-off-by: Tian Kevin <kevin.tian@intel.com> >>>> Signed-off-by: Wei Gang <gang.wei@intel.com> >>> >>> Are the changes done here native-compatible? They don''t really looklike>>> they are from a brief inspection... I''d be glad to read a closer >>> explanation of what is being attempted here. >> >> These changes should be native-compatible. We are attempting to make >> ACPI info parsing work for all physical cpus even dom0 vcpu nr < phys >> cpu nr. UP dom0 is a case requested by Keir for xen server probablygo>> in that way. Without these changes, only BSP ACPI info can be parsedand>> passed to HV. Is that clear for you? Or any further comments? > > I understand the intention, but I''m worried about breaking native > kernels: If the changes you made are appropriate for native, then > why aren''t they upstream? And if they aren''t or if there is any doubt, > then they ought to at least be contained in #ifdef CONFIG_XEN blocks > (but of course I''d much prefer not having many of these in generic > code, and even more in ACPI CA code).Most of these changes don''t have any impact if no additional linux kernel parameter (xen_processor_pmbits=) was added to kernel cmdline by Xen or manually in grub.conf. Is it still necessary to add #ifdef CONFIG_XEN even if those changes have no impact by default? Jimmy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jan Beulich
2008-Apr-29 10:16 UTC
RE: [Xen-devel] [PATCH 8/9] Add cpu idle pwr mgmt to xen
>Most of these changes don''t have any impact if no additional linux >kernel parameter (xen_processor_pmbits=) was added to kernel cmdline by >Xen or manually in grub.conf. Is it still necessary to add #ifdef >CONFIG_XEN even if those changes have no impact by default?I would say so, but of course this is Keir''s call (if he doesn''t demand it, we''ll have to add the respective conditionals in our fixup patches, unless it can be proven that the changes a benign for native). Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2008-Apr-29 10:26 UTC
Re: [Xen-devel] [PATCH 8/9] Add cpu idle pwr mgmt to xen
On 29/4/08 11:16, "Jan Beulich" <jbeulich@novell.com> wrote:>> Most of these changes don''t have any impact if no additional linux >> kernel parameter (xen_processor_pmbits=) was added to kernel cmdline by >> Xen or manually in grub.conf. Is it still necessary to add #ifdef >> CONFIG_XEN even if those changes have no impact by default? > > I would say so, but of course this is Keir''s call (if he doesn''t demand it, > we''ll have to add the respective conditionals in our fixup patches, > unless it can be proven that the changes a benign for native).I agree it''s probably good practice to use #ifdef CONFIG_XEN. -- Keir> Jan > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Tuesday, April 29, 2008 6:27 PM, Keir Fraser wrote:> On 29/4/08 11:16, "Jan Beulich" <jbeulich@novell.com> wrote: > >>> Most of these changes don''t have any impact if no additional linux >>> kernel parameter (xen_processor_pmbits=) was added to kernel cmdlineby>>> Xen or manually in grub.conf. Is it still necessary to add #ifdef >>> CONFIG_XEN even if those changes have no impact by default? >> >> I would say so, but of course this is Keir''s call (if he doesn''tdemand>> it, we''ll have to add the respective conditionals in our fixuppatches,>> unless it can be proven that the changes a benign for native). > > I agree it''s probably good practice to use #ifdef CONFIG_XEN.Ok, I can add it and will resend the dom0 patches after gaining enough feedbacks for them. Jimmy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel