john.levon@sun.com
2008-Apr-15 21:54 UTC
[Xen-devel] [PATCH] Fix xenstore-client.c compile
# HG changeset patch
# User john.levon@sun.com
# Date 1208291972 25200
# Node ID 9252f597874dde20b03fd3ba7d85fd1dd45d4e54
# Parent 8c0eab12df75f997458fad96304cc7927e8ef90c
Fix xenstore-client.c compile
errx() is not necessarily defined as a never-returns function. Fix
lookup_mode() to account for this.
Signed-off-by: John Levon <john.levon@sun.com>
diff --git a/tools/xenstore/xenstore_client.c b/tools/xenstore/xenstore_client.c
--- a/tools/xenstore/xenstore_client.c
+++ b/tools/xenstore/xenstore_client.c
@@ -450,8 +450,9 @@ static enum mode lookup_mode(const char
return MODE_write;
else if (strcmp(m, "read") == 0)
return MODE_read;
- else
- errx(1, "unknown mode %s\n", m);
+
+ errx(1, "unknown mode %s\n", m);
+ return 0;
}
int
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
john.levon@Sun.COM
2008-Apr-30 12:54 UTC
[Xen-devel] [PATCH] Fix xenstore-client.c compile
# HG changeset patch
# User john.levon@sun.com
# Date 1209521786 25200
# Node ID 2838606c439eba685f8b791ceb5d1b0e84bc7e9e
# Parent c4902db497fc7e6fbee16633b9f09bbd28239bc4
Fix xenstore-client.c compile
errx() is not necessarily defined as a never-returns function. Fix
lookup_mode() to account for this.
Signed-off-by: John Levon <john.levon@sun.com>
diff --git a/tools/xenstore/xenstore_client.c b/tools/xenstore/xenstore_client.c
--- a/tools/xenstore/xenstore_client.c
+++ b/tools/xenstore/xenstore_client.c
@@ -450,8 +450,9 @@ static enum mode lookup_mode(const char
return MODE_write;
else if (strcmp(m, "read") == 0)
return MODE_read;
- else
- errx(1, "unknown mode %s\n", m);
+
+ errx(1, "unknown mode %s\n", m);
+ return 0;
}
int
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel