The Xen source tree currently contains a copy of the figlet sources. During the hypervisor build it builds figlet and uses it to generate the big ascii art ''Xen 3.1.0'' version string shown upon boot. The problem is that the figlet code is licensed under the original Artistic 1.0 license, and not the clarified version. The original non-clarified license is classed as non-free by Debian and on the forbidden list for Fedora too: http://fedoraproject.org/wiki/Licensing#head-d8cc605dd386091c8b6be97b8a43fb6a5d624ae1 So, the figlet source code in Xen has to be removed if we''re to continue shipping Xen in Fedora. While I could re-spin the source tar.gz files myself before importing them to Fedora, it''d be preferrable if the official Xen source code tar.gz were shipped without figlet in the first place. I''m happy to send a patch to clean this up - just wondering which option would be preferred... - Remove figlet entirely and just have a normal size "Xen 3.1.0" string printed at boot - Include the pre-generated large ascii art "Xen" and have normal size "3.1.0" version stirng. - Optionally call out to a plain figlet binary in $PATH, using a normal size version string if not found. Personally I''d just go for option 1 or 2 since they''re least effort... Dan. -- |: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Alternately - a clone could be used: http://freshmeat.net/projects/toilet/ http://libcaca.zoy.org/toilet.html (LGPL) Daniel P. Berrange wrote:> The Xen source tree currently contains a copy of the figlet sources. During > the hypervisor build it builds figlet and uses it to generate the big ascii > art ''Xen 3.1.0'' version string shown upon boot. > > The problem is that the figlet code is licensed under the original Artistic > 1.0 license, and not the clarified version. The original non-clarified > license is classed as non-free by Debian and on the forbidden list for > Fedora too: > > http://fedoraproject.org/wiki/Licensing#head-d8cc605dd386091c8b6be97b8a43fb6a5d624ae1 > > So, the figlet source code in Xen has to be removed if we''re to continue > shipping Xen in Fedora. While I could re-spin the source tar.gz files myself > before importing them to Fedora, it''d be preferrable if the official Xen > source code tar.gz were shipped without figlet in the first place. > > I''m happy to send a patch to clean this up - just wondering which option > would be preferred... > > - Remove figlet entirely and just have a normal size "Xen 3.1.0" string > printed at boot > - Include the pre-generated large ascii art "Xen" and have normal size > "3.1.0" version stirng. > - Optionally call out to a plain figlet binary in $PATH, using a normal > size version string if not found. > > Personally I''d just go for option 1 or 2 since they''re least effort... > > Dan. >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
What a rathole this could be. Let''s cache the figlet output across builds and add a ''make tarball'' target which for now just: 1. Runs figlet. 2. Deletes figlet. 3. tar czf ... -- Keir On 21/4/08 18:31, "Ben Guthro" <bguthro@virtualiron.com> wrote:> Alternately - a clone could be used: > > http://freshmeat.net/projects/toilet/ > http://libcaca.zoy.org/toilet.html > (LGPL) > > Daniel P. Berrange wrote: >> The Xen source tree currently contains a copy of the figlet sources. During >> the hypervisor build it builds figlet and uses it to generate the big ascii >> art ''Xen 3.1.0'' version string shown upon boot. >> >> The problem is that the figlet code is licensed under the original Artistic >> 1.0 license, and not the clarified version. The original non-clarified >> license is classed as non-free by Debian and on the forbidden list for >> Fedora too: >> >> http://fedoraproject.org/wiki/Licensing#head-d8cc605dd386091c8b6be97b8a43fb6a >> 5d624ae1 >> >> So, the figlet source code in Xen has to be removed if we''re to continue >> shipping Xen in Fedora. While I could re-spin the source tar.gz files myself >> before importing them to Fedora, it''d be preferrable if the official Xen >> source code tar.gz were shipped without figlet in the first place. >> >> I''m happy to send a patch to clean this up - just wondering which option >> would be preferred... >> >> - Remove figlet entirely and just have a normal size "Xen 3.1.0" string >> printed at boot >> - Include the pre-generated large ascii art "Xen" and have normal size >> "3.1.0" version stirng. >> - Optionally call out to a plain figlet binary in $PATH, using a normal >> size version string if not found. >> >> Personally I''d just go for option 1 or 2 since they''re least effort... >> >> Dan. >> > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Daniel P. Berrange
2008-Apr-21 18:24 UTC
Re: [Xen-devel] RFC: removing figlet source from Xen
On Mon, Apr 21, 2008 at 07:08:28PM +0100, Keir Fraser wrote:> What a rathole this could be. Let''s cache the figlet output across builds > and add a ''make tarball'' target which for now just: > 1. Runs figlet. > 2. Deletes figlet. > 3. tar czf ...Can''t we just remove figlet completely & avoid the huge banner for the version number. Its not like anyone really watches/needs that stuff. Dan. -- |: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 21/4/08 19:24, "Daniel P. Berrange" <berrange@redhat.com> wrote:> On Mon, Apr 21, 2008 at 07:08:28PM +0100, Keir Fraser wrote: >> What a rathole this could be. Let''s cache the figlet output across builds >> and add a ''make tarball'' target which for now just: >> 1. Runs figlet. >> 2. Deletes figlet. >> 3. tar czf ... > > Can''t we just remove figlet completely & avoid the huge banner for the > version number. Its not like anyone really watches/needs that stuff. > > Dan.No. :-) -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 21/4/08 19:26, "Keir Fraser" <keir.fraser@eu.citrix.com> wrote:>> On Mon, Apr 21, 2008 at 07:08:28PM +0100, Keir Fraser wrote: >>> What a rathole this could be. Let''s cache the figlet output across builds >>> and add a ''make tarball'' target which for now just: >>> 1. Runs figlet. >>> 2. Deletes figlet. >>> 3. tar czf ... >> >> Can''t we just remove figlet completely & avoid the huge banner for the >> version number. Its not like anyone really watches/needs that stuff. >> >> Dan. > > No. :-)Changeset 17488. Just need to remember to ''make src-tarball'' when we make source tarballs. Shouldn''t be hard to remember, but you can make your own tarballs really easily anyway. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel