Xen devel - Oct 2007 - [PATCH] linux-2.6.18-xen.hg: check that awk supports ''gensub'' command

The linux-2.6.18-xen.hg/scripts/Makefile.xen.awk script depends on the 
GNU AWK-specific function "gensub".  If another awk is used (e.g., 
Debian installs mawk by default), the lack of gensub trickles down to 
cause the -xen.c files to not be compiled.  This was time-consuming to 
track.  So we should check that the awk program supports
''gensub''.

Signed-off-by: Michael Abd-El-Malek <mabdelmalek@cmu.edu>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

>>> Michael Abd-El-Malek <mabdelmalek@cmu.edu> 10.10.07 04:53
>>>
>The linux-2.6.18-xen.hg/scripts/Makefile.xen.awk script depends on the 
>GNU AWK-specific function "gensub".  If another awk is used (e.g.,
>Debian installs mawk by default), the lack of gensub trickles down to 
>cause the -xen.c files to not be compiled.  This was time-consuming to 
>track.  So we should check that the awk program supports
''gensub''.
>
>Signed-off-by: Michael Abd-El-Malek <mabdelmalek@cmu.edu>
Hmm, this seems odd: If I try to use an arbitrary function (with gawk) , I get a
failure, which should prevent make from continuing the build. Are you saying
this isn''t happening for you? Have you determined why?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 10/10/07 08:54, "Jan Beulich" <jbeulich@novell.com> wrote:
>>>> Michael Abd-El-Malek <mabdelmalek@cmu.edu> 10.10.07 04:53
>>>
>> The linux-2.6.18-xen.hg/scripts/Makefile.xen.awk script depends on the
>> GNU AWK-specific function "gensub".  If another awk is used
(e.g.,
>> Debian installs mawk by default), the lack of gensub trickles down to
>> cause the -xen.c files to not be compiled.  This was time-consuming to
>> track.  So we should check that the awk program supports
''gensub''.
>> 
>> Signed-off-by: Michael Abd-El-Malek <mabdelmalek@cmu.edu>
> 
> Hmm, this seems odd: If I try to use an arbitrary function (with gawk) , I
get
> a
> failure, which should prevent make from continuing the build. Are you
saying
> this isn''t happening for you? Have you determined why?
The implication seems to be that other awk implementations (most likely mawk
in this case) silently continue.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Oct 10, 2007, at 4:47 AM, Keir Fraser wrote:
> On 10/10/07 08:54, "Jan Beulich" <jbeulich@novell.com>
wrote:
>
>>>>> Michael Abd-El-Malek <mabdelmalek@cmu.edu> 10.10.07
04:53 >>>
>>> The linux-2.6.18-xen.hg/scripts/Makefile.xen.awk script depends  
>>> on the
>>> GNU AWK-specific function "gensub".  If another awk is
used (e.g.,
>>> Debian installs mawk by default), the lack of gensub trickles  
>>> down to
>>> cause the -xen.c files to not be compiled.  This was time- 
>>> consuming to
>>> track.  So we should check that the awk program supports
''gensub''.
>>>
>>> Signed-off-by: Michael Abd-El-Malek <mabdelmalek@cmu.edu>
>>
>> Hmm, this seems odd: If I try to use an arbitrary function (with  
>> gawk) , I get
>> a
>> failure, which should prevent make from continuing the build. Are  
>> you saying
>> this isn''t happening for you? Have you determined why?
>
> The implication seems to be that other awk implementations (most  
> likely mawk
> in this case) silently continue.
>
>  -- Keir
Yes, the build process would continue with mawk silently failing.   
The resulting build problems have been encountered by others before;  
see:
http://lists.xensource.com/archives/html/xen-devel/2007-07/msg00840.html

Mike

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel