Christoph Egger
2007-Sep-27 11:35 UTC
[Xen-devel] [PATCH][TOOLS] ioemu: Build fixes for BSD and bug fixes from BSD
Hi! Attached patch makes ioemu build on *BSD. It also applies bug fixes from *BSD for Linux and *BSD :-) Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> P.S.: Could someone with contact to qemu people make this patch go upstream to qemu, please? -- AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2007-Sep-27 14:19 UTC
Re: [Xen-devel] [PATCH][TOOLS] ioemu: Build fixes for BSD and bug fixes from BSD
On 27/9/07 12:35, "Christoph Egger" <Christoph.Egger@amd.com> wrote:> Attached patch makes ioemu build on *BSD. > It also applies bug fixes from *BSD for Linux and *BSD :-) > > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> > > P.S.: Could someone with contact to qemu people make this patch > go upstream to qemu, please?Why the setenv PTHREAD_DIAGASSERT? There is very little pthread usage at all in ioemu. In fact basically none. And why do you need to fiddle with {get,set}rlimit()? Is ioemu stack usage excessive? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger
2007-Sep-27 14:35 UTC
Re: [Xen-devel] [PATCH][TOOLS] ioemu: Build fixes for BSD and bug fixes from BSD
On Thursday 27 September 2007 16:19:42 Keir Fraser wrote:> On 27/9/07 12:35, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > > Attached patch makes ioemu build on *BSD. > > It also applies bug fixes from *BSD for Linux and *BSD :-) > > > > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> > > > > P.S.: Could someone with contact to qemu people make this patch > > go upstream to qemu, please? > > Why the setenv PTHREAD_DIAGASSERT? There is very little pthread usage at > all in ioemu. In fact basically none.Oh, a debugging leftover. You may kill that.> And why do you need to fiddle with {get,set}rlimit()? Is ioemu stack usage > excessive?The resource limits on BSD are more limited than on Linux. Look: NetBSD: ulimit -a ----------------- time(cpu-seconds) unlimited file(blocks) unlimited coredump(blocks) unlimited data(kbytes) 262144 stack(kbytes) 2048 lockedmem(kbytes) 1111329 memory(kbytes) 3333988 nofiles(descriptors) 64 processes 160 sbsize(bytes) unlimited ----------------- OpenBSD: ulimit -a -------------------- time(cpu-seconds) unlimited file(blocks) unlimited coredump(blocks) unlimited data(kbytes) 524288 stack(kbytes) 4096 lockedmem(kbytes) 335258 memory(kbytes) 1004356 nofiles(descriptors) 128 processes 128 ---------------------- Linux: ulimit -a ----------------------- core file size (blocks, -c) 0 data seg size (kbytes, -d) unlimited scheduling priority (-e) 20 file size (blocks, -f) unlimited pending signals (-i) unlimited max locked memory (kbytes, -l) unlimited max memory size (kbytes, -m) unlimited open files (-n) 1024 pipe size (512 bytes, -p) 8 POSIX message queues (bytes, -q) unlimited real-time priority (-r) 0 stack size (kbytes, -s) 8192 cpu time (seconds, -t) unlimited max user processes (-u) unlimited virtual memory (kbytes, -v) unlimited file locks (-x) unlimited ----------------------- -- AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2007-Sep-27 15:39 UTC
Re: [Xen-devel] [PATCH][TOOLS] ioemu: Build fixes for BSD and bug fixes from BSD
On 27/9/07 12:35, "Christoph Egger" <Christoph.Egger@amd.com> wrote:> Hi! > > Attached patch makes ioemu build on *BSD. > It also applies bug fixes from *BSD for Linux and *BSD :-) > > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>I checked in all the bits that look like they are there just to make ioemu build and run on *BSD (that''s about 90-95% of the patch). The remainder I rejected -- that''s generic bug fixes to ioemu (belongs upstream and/or as separate patches to xen-devel) and anything that looked like it merely fixes a build warning (we don''t build ioemu with -Werror, and we tolerate build warnings because they should really be fixed upstream first). You may want to check that I didn''t cut too hard, and resubmit a few bits. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger
2007-Sep-28 08:07 UTC
Re: [Xen-devel] [PATCH][TOOLS] ioemu: Build fixes for BSD and bug fixes from BSD
On Thursday 27 September 2007 17:39:18 Keir Fraser wrote:> On 27/9/07 12:35, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > > Hi! > > > > Attached patch makes ioemu build on *BSD. > > It also applies bug fixes from *BSD for Linux and *BSD :-) > > > > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> > > I checked in all the bits that look like they are there just to make ioemu > build and run on *BSD (that''s about 90-95% of the patch). The remainder I > rejected -- that''s generic bug fixes to ioemu (belongs upstream and/or as > separate patches to xen-devel) and anything that looked like it merely > fixes a build warning (we don''t build ioemu with -Werror, and we tolerate > build warnings because they should really be fixed upstream first).I agree with you, this also should go into qemu. But I don''t have contact to the qemu people. That''s why I asked in the first signed-off mail, if there is someone with contact to qemu. Maybe someone from qemu is subscribed on xen-devel, so I resubmit the remainder as separate patch. Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>> You may want to check that I didn''t cut too hard, and resubmit a few bits. > > -- KeirI just checked. I can live with that what you committed. But I resubmit the remainder for the case someone from qemu is on xen-devel or someone with contact to qemu people is on xen-devel, in hope the *full* patch goes into qemu the one or the other way. Christoph -- AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Campbell
2007-Sep-28 10:31 UTC
Re: [Xen-devel] [PATCH][TOOLS] ioemu: Build fixes for BSD and bug fixes from BSD
On Fri, 2007-09-28 at 10:07 +0200, Christoph Egger wrote:> I agree with you, this also should go into qemu. But I don''t have > contact to the qemu people.You could post to qemu-devel. http://lists.nongnu.org/mailman/listinfo/qemu-devel Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel