Wake sts is only required to be checked for S1, and implementation is free to not touch wake sts bit for S3. The latter case is observed falling into loop on checking wake sts after sleep hypercall returns. Actually we only need to check hypercall return value here, and those checks belong to Xen instead. (For linux-xen staging) Signed-off-by Kevin Tian <kevin.tian@intel.com> Thanks, Kevin _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2007-Sep-07 10:21 UTC
Re: [Xen-devel] [PATCH] Fix one dead loop case in host S3
Applied. It looks like Xen''s XENPF_enter_acpi_sleep command only gets invoked after the second write to the pm1a/pm1b control ports. So do we actually need first-write handling in that hypercall? Is it going to be used in future? -- Keir On 6/9/07 08:05, "Tian, Kevin" <kevin.tian@intel.com> wrote:> Wake sts is only required to be checked for S1, and implementation > is free to not touch wake sts bit for S3. The latter case is observed > falling into loop on checking wake sts after sleep hypercall returns. > Actually we only need to check hypercall return value here, and those > checks belong to Xen instead. > > (For linux-xen staging) > Signed-off-by Kevin Tian <kevin.tian@intel.com> > > Thanks, > Kevin > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Tian, Kevin
2007-Sep-07 10:24 UTC
RE: [Xen-devel] [PATCH] Fix one dead loop case in host S3
>From: Keir Fraser [mailto:Keir.Fraser@cl.cam.ac.uk] >Sent: 2007年9月7日 18:22 > >Applied. It looks like Xen''s XENPF_enter_acpi_sleep command only >gets >invoked after the second write to the pm1a/pm1b control ports. So do we >actually need first-write handling in that hypercall? Is it going to be used >in future? > > -- KeirDon''t need actually. I''ll make a patch later. Thanks, Kevin _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel