John Levon
2007-Jul-26 13:43 UTC
Re: [Xen-devel] [PATCH] [XEND] Modprobe vlan support before trying to use vconfig
On Thu, Jul 26, 2007 at 09:47:42AM -0400, Stefan Berger wrote:> +def linux_enable_vlan(): > + global modprobed_8021qcould this please go in osdep.py with the rest of the OS-specific stuff*, and just have an osdep.enable_vlan() function? thanks john * well, apart from all the new Linux-specific code there is... _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Stefan Berger
2007-Jul-26 13:47 UTC
[Xen-devel] [PATCH] [XEND] Modprobe vlan support before trying to use vconfig
This patch makes sure that vlan support is available before vconfig is used (on Linux). An attempt is made to ''modprobe 8021q'' to enable this feature on those systems where it might have been compiled as a module. A warning is left in the log if VLAN could not be enabled. Signed-off-by: Stefan Berger <stefanb@us.ibm.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Stefan Berger
2007-Jul-26 13:56 UTC
Re: [Xen-devel] [PATCH] [XEND] Modprobe vlan support before trying to use vconfig
John Levon <levon@movementarian.org> wrote on 07/26/2007 09:43:57 AM:> On Thu, Jul 26, 2007 at 09:47:42AM -0400, Stefan Berger wrote: > > > +def linux_enable_vlan(): > > + global modprobed_8021q > > could this please go in osdep.py with the rest of the OS-specific > stuff*, and just have an osdep.enable_vlan() function?Ok, I will do that. Thanks Stefan> > thanks > john > > * well, apart from all the new Linux-specific code there is..._______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Stefan Berger
2007-Jul-26 15:50 UTC
Re: [Xen-devel] [PATCH] [XEND] Modprobe vlan support before trying to use vconfig
xen-devel-bounces@lists.xensource.com wrote on 07/26/2007 09:43:57 AM:> On Thu, Jul 26, 2007 at 09:47:42AM -0400, Stefan Berger wrote: > > > +def linux_enable_vlan(): > > + global modprobed_8021q > > could this please go in osdep.py with the rest of the OS-specific > stuff*, and just have an osdep.enable_vlan() function?Now after these other two patches that I just committed, the problem with the vlan creation is gone and the only benefit of such a function osdep.enable_vlan() would be to print out a warning message into the log file to indicate that VLAN support is not available on the system (after a failed modprobe). Not sure whether it is worth such a function, though, but might be useful for debugging. Comments? Stefan> > thanks > john > > * well, apart from all the new Linux-specific code there is... > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel