Xen devel - Jul 2007 - [PATCH]Clean up es7000 specific bootup code

This patch cleans out Unisys es7000 platform specific code. A lot of the
code there was not required since it is for legacy es7000s on which Xen
is not supported.
I also removed calls to enable_apic_mode from apic.c since that is also
legacy es7000 specific code.
This patch has been tested on a commodity Dell box and an Unisys es7000
Raj



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Applied. And you''ll see that I was able to strip out even more code, in
particular variable es7000_plat just disappeared.

Now I think we could go further, as es7000 now just looks like bigsmp. If we
got rid of the es7000 genapic altogether, would your systems always fall
back to bigsmp? If not, you might need to add a Unisys OEM check to the DMI
checks in arch/x86/genapic/bigsmp.c. But I think that would be a small
addition there, and allow you to completely remove all other vestiges of
es7000-specific code, making maintenance in future easier.

Could you look into this?

 -- Keir

On 10/7/07 02:47, "Subrahmanian, Raj"
<raj.subrahmanian@unisys.com> wrote:
> This patch cleans out Unisys es7000 platform specific code. A lot of the
> code there was not required since it is for legacy es7000s on which Xen
> is not supported.
> I also removed calls to enable_apic_mode from apic.c since that is also
> legacy es7000 specific code.
> This patch has been tested on a commodity Dell box and an Unisys es7000
> Raj
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

I will look into it.
Raj 
>-----Original Message-----
>From: Keir Fraser [mailto:keir@xensource.com] 
>Sent: Tuesday, July 10, 2007 5:09 AM
>To: Subrahmanian, Raj
>Cc: xen-devel@lists.xensource.com
>Subject: Re: [Xen-devel] [PATCH]Clean up es7000 specific bootup code 
>
>Applied. And you''ll see that I was able to strip out even more 
>code, in particular variable es7000_plat just disappeared.
>
>Now I think we could go further, as es7000 now just looks like 
>bigsmp. If we got rid of the es7000 genapic altogether, would 
>your systems always fall back to bigsmp? If not, you might 
>need to add a Unisys OEM check to the DMI checks in 
>arch/x86/genapic/bigsmp.c. But I think that would be a small 
>addition there, and allow you to completely remove all other 
>vestiges of es7000-specific code, making maintenance in future easier.
>
>Could you look into this?
>
> -- Keir
>
>On 10/7/07 02:47, "Subrahmanian, Raj" 
><raj.subrahmanian@unisys.com> wrote:
>
>> This patch cleans out Unisys es7000 platform specific code. A lot of 
>> the code there was not required since it is for legacy es7000s on 
>> which Xen is not supported.
>> I also removed calls to enable_apic_mode from apic.c since that is 
>> also legacy es7000 specific code.
>> This patch has been tested on a commodity Dell box and an Unisys 
>> es7000 Raj
>> 
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xensource.com
>> http://lists.xensource.com/xen-devel
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Keir 
>Applied. And you''ll see that I was able to strip out even more 
>code, in particular variable es7000_plat just disappeared.
>
>Now I think we could go further, as es7000 now just looks like 
>bigsmp. If we got rid of the es7000 genapic altogether, would 
>your systems always fall back to bigsmp? If not, you might 
>need to add a Unisys OEM check to the DMI checks in 
>arch/x86/genapic/bigsmp.c. But I think that would be a small 
>addition there, and allow you to completely remove all other 
>vestiges of es7000-specific code, making maintenance in future easier.
>
>Could you look into this?
This patch removes the rest of the ES7000 genapic and adds an Unisys OEM
check into bigsmp.c.

Raj

Rajagopalan Subrahmanian
ES7000 Linux Systems Group
Unisys - Systems and Technology


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel