john.levon@sun.com
2007-Jun-14 23:00 UTC
[Xen-devel] [PATCH] Prevent attachment of devices in dom0
# HG changeset patch
# User john.levon@sun.com
# Date 1181861914 25200
# Node ID 7790a6395ed398fffb85ec8eef184d6c8c83b8c4
# Parent 1e09661173844517d8c7b73822d2067afed2d098
Prevent attachment of devices in dom0
Signed-off-by: Gary Pennington <gary.pennington@sun.com>
diff --git a/tools/python/xen/xend/XendDomainInfo.py
b/tools/python/xen/xend/XendDomainInfo.py
--- a/tools/python/xen/xend/XendDomainInfo.py
+++ b/tools/python/xen/xend/XendDomainInfo.py
@@ -497,6 +497,10 @@ class XendDomainInfo:
@param dev_config: device configuration
@type dev_config: SXP object (parsed config)
"""
+
+ if self.domid == 0:
+ raise XendError(''Devices cannot be attached to Domain
0'')
+
log.debug("XendDomainInfo.device_create: %s" %
scrub_password(dev_config))
dev_type = sxp.name(dev_config)
dev_uuid = self.info.device_add(dev_type, cfg_sxp = dev_config)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Brendan Cully
2007-Jun-14 23:07 UTC
Re: [Xen-devel] [PATCH] Prevent attachment of devices in dom0
I''d prefer to be able to block-attach things in domain 0 on occasion. It''s a pretty convenient way to set up and maintain blocktap filesystems. Maybe you can move this policy somewhere closer to the problem you are fixing? On Thursday, 14 June 2007 at 16:00, john.levon@sun.com wrote:> # HG changeset patch > # User john.levon@sun.com > # Date 1181861914 25200 > # Node ID 7790a6395ed398fffb85ec8eef184d6c8c83b8c4 > # Parent 1e09661173844517d8c7b73822d2067afed2d098 > Prevent attachment of devices in dom0 > > Signed-off-by: Gary Pennington <gary.pennington@sun.com> > > diff --git a/tools/python/xen/xend/XendDomainInfo.py b/tools/python/xen/xend/XendDomainInfo.py > +++ b/tools/python/xen/xend/XendDomainInfo.py > @@ -497,6 +497,10 @@ class XendDomainInfo: > @param dev_config: device configuration > @type dev_config: SXP object (parsed config) > """ > + > + if self.domid == 0: > + raise XendError(''Devices cannot be attached to Domain 0'') > + > log.debug("XendDomainInfo.device_create: %s" % scrub_password(dev_config)) > dev_type = sxp.name(dev_config) > dev_uuid = self.info.device_add(dev_type, cfg_sxp = dev_config) > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel