Jim Fehlig
2007-Jun-06 01:21 UTC
[Xen-devel] [PATCH][xend] Fix handling of scheduler params
When creating domains that specify scheduler parameters with XenAPI, the
specified parameters are not used when starting the domain. As an
example, here is a snippet of internal config for a domain created via
XenAPI that contains scheduling params:
(domain
(domid 6)
(vcpus_params ((cap 100) (weight 512)))
...
(cpu_weight 256)
(cpu_cap 0)
...
)
Starting the domain results in following scheduler settings:
jfehlig4:/home/jfehlig/cim/cimxml # xm sched-credit -d sles10_nographic
Name ID Weight Cap
sles10_nographic 6 256 0
The attached patch collapses cpu_weight and cpu_cap in XendConfig into
the vcpus_params dictionary. The patch has been tested using xm and
XenAPI on config with and without scheduler parameters.
Regards,
Jim
Signed-off-by: Jim Fehlig <jfehlig@novell.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Masaki Kanno
2007-Jun-06 11:20 UTC
Re: [Xen-devel] [PATCH][xend] Fix handling of scheduler params
Hi Jim, If the patch is applied, I think that "cpu_weight" and "cpu_cap" disappear from information of xm list. Is my thought right? Best regards, Kan>When creating domains that specify scheduler parameters with XenAPI, the >specified parameters are not used when starting the domain. As an >example, here is a snippet of internal config for a domain created via >XenAPI that contains scheduling params: > >(domain > (domid 6) > (vcpus_params ((cap 100) (weight 512))) > ... > (cpu_weight 256) > (cpu_cap 0) > ... >) > >Starting the domain results in following scheduler settings: > >jfehlig4:/home/jfehlig/cim/cimxml # xm sched-credit -d sles10_nographic >Name ID Weight Cap >sles10_nographic 6 256 0 > >The attached patch collapses cpu_weight and cpu_cap in XendConfig into >the vcpus_params dictionary. The patch has been tested using xm and >XenAPI on config with and without scheduler parameters. > >Regards, >Jim > >Signed-off-by: Jim Fehlig <jfehlig@novell.com> > > > >-------------------------------text/plain------------------------------- >_______________________________________________ >Xen-devel mailing list >Xen-devel@lists.xensource.com >http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jim Fehlig
2007-Jun-06 15:12 UTC
Re: [Xen-devel] [PATCH][xend] Fix handling of scheduler params
Masaki Kanno wrote:> Hi Jim, > > If the patch is applied, I think that "cpu_weight" and "cpu_cap" > disappear from information of xm list. Is my thought right? >If xm is using the legacy interface, then yes ''xm list --long <dom>'' does not contain cpu_weight|cap. The info is available using xm sched, e.g. jfehlig4:~ # xm sched-credit -d sles10_nographic Name ID Weight Cap sles10_nographic 29 512 50 Domain must be running however - but this is also true to change the values. If xm is configured to use XenAPI, which I understand will be the default soon, you get: jfehlig4:/usr/lib64/python/site-packages/xen/xend # xm li -l sles10_graphics (domain (PV_args ''TERM=xterm '') (VIFs (bea9a278-a393-0186-210b-ea6f45870468)) (PV_bootloader /usr/lib/xen/boot/domUloader.py) (VTPMs ()) ... (VCPUs_params "{''cap'': ''50'', ''weight'': ''512''}") ... ) Note that using either or both cpu_weight|cap in domain config file works as before. How to proceed with this patch depends on when/if xm will be moved to XenAPI. If this will not occur for some time, then I should adjust the patch to preserve cpu_weight|cap in sexpr. Regards, Jim> Best regards, > Kan > > >> When creating domains that specify scheduler parameters with XenAPI, the >> specified parameters are not used when starting the domain. As an >> example, here is a snippet of internal config for a domain created via >> XenAPI that contains scheduling params: >> >> (domain >> (domid 6) >> (vcpus_params ((cap 100) (weight 512))) >> ... >> (cpu_weight 256) >> (cpu_cap 0) >> ... >> ) >> >> Starting the domain results in following scheduler settings: >> >> jfehlig4:/home/jfehlig/cim/cimxml # xm sched-credit -d sles10_nographic >> Name ID Weight Cap >> sles10_nographic 6 256 0 >> >> The attached patch collapses cpu_weight and cpu_cap in XendConfig into >> the vcpus_params dictionary. The patch has been tested using xm and >> XenAPI on config with and without scheduler parameters. >> >> Regards, >> Jim >> >> Signed-off-by: Jim Fehlig <jfehlig@novell.com> >> >> >> >> -------------------------------text/plain------------------------------- >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel >> > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Masaki Kanno
2007-Jun-07 09:21 UTC
Re: [Xen-devel] [PATCH][xend] Fix handling of scheduler params
>Masaki Kanno wrote: >> Hi Jim, >> >> If the patch is applied, I think that "cpu_weight" and "cpu_cap" >> disappear from information of xm list. Is my thought right? >> > >If xm is using the legacy interface, then yes ''xm list --long <dom>'' >does not contain cpu_weight|cap. The info is available using xm sched, >e.g. > >jfehlig4:~ # xm sched-credit -d sles10_nographic >Name ID Weight Cap >sles10_nographic 29 512 50 > >Domain must be running however - but this is also true to change the >values. > >If xm is configured to use XenAPI, which I understand will be the >default soon, you get: > >jfehlig4:/usr/lib64/python/site-packages/xen/xend # xm li -l sles10_graphics >(domain > (PV_args ''TERM=xterm '') > (VIFs (bea9a278-a393-0186-210b-ea6f45870468)) > (PV_bootloader /usr/lib/xen/boot/domUloader.py) > (VTPMs ()) > ... > > (VCPUs_params "{''cap'': ''50'', ''weight'': ''512''}") > ... >) > >Note that using either or both cpu_weight|cap in domain config file >works as before. > >How to proceed with this patch depends on when/if xm will be moved to >XenAPI. If this will not occur for some time, then I should adjust the >patch to preserve cpu_weight|cap in sexpr.Hi Jim, I think that configuration and state of domain had better be shown only by information of xm list command. But I think that the patch is necessary for XenAPI. Therefore I do not intend to deny the patch. I hope that xm is moved to XenAPI. Or to show values of both cpu_weight and cpu_cap of non-running managed domain, I may post a patch for xm sched command. Best regards, Kan> >Regards, >Jim > >> Best regards, >> Kan >> >> >>> When creating domains that specify scheduler parameters with XenAPI, the >>> specified parameters are not used when starting the domain. As an >>> example, here is a snippet of internal config for a domain created via >>> XenAPI that contains scheduling params: >>> >>> (domain >>> (domid 6) >>> (vcpus_params ((cap 100) (weight 512))) >>> ... >>> (cpu_weight 256) >>> (cpu_cap 0) >>> ... >>> ) >>> >>> Starting the domain results in following scheduler settings: >>> >>> jfehlig4:/home/jfehlig/cim/cimxml # xm sched-credit -d sles10_nographic >>> Name ID Weight Cap >>> sles10_nographic 6 256 0 >>> >>> The attached patch collapses cpu_weight and cpu_cap in XendConfig into >>> the vcpus_params dictionary. The patch has been tested using xm and >>> XenAPI on config with and without scheduler parameters. >>> >>> Regards, >>> Jim >>> >>> Signed-off-by: Jim Fehlig <jfehlig@novell.com> >>> >>> >>> >>> -------------------------------text/plain------------------------------- >>> _______________________________________________ >>> Xen-devel mailing list >>> Xen-devel@lists.xensource.com >>> http://lists.xensource.com/xen-devel >>> >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel >> > >_______________________________________________ >Xen-devel mailing list >Xen-devel@lists.xensource.com >http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel