Hi all, The coding style in the Xen tree is somewhat varied these days - there are a few deviations from the "standard" that have crept in over time. I''ve been trying to think of ways we can help contributors understand how the code is supposed to look in a canonical form, rather than people trying to judge from code already there. Attached is a little extra documentation - my quick stab at summing up the Xen coding style. I think the main points of difference from the Linux coding style are summarised here, but if anybody has anything else they think should be included (or anything they disagree with in my summary) it would be handy to know. I''ve also attached a modified-for-Xen version of a (the?) Linux patch style checker. It might not be 100% accurate, but it should give folks a pretty good idea of any obvious style changes they need to make. My hope is that this will reduce review burden (for reviewers and submitters) and eventually get the codebase back towards a uniform coding style. This is a component of my exploration of automated code quality checking for the Xen codebase. Comments, anyone? Cheers, Mark -- Dave: Just a question. What use is a unicyle with no seat? And no pedals! Mark: To answer a question with a question: What use is a skateboard? Dave: Skateboards have wheels. Mark: My wheel has a wheel! _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 4/6/07 06:03, "Mark Williamson" <mark.williamson@cl.cam.ac.uk> wrote:> Attached is a little extra documentation - my quick stab at summing up the Xen > coding style. I think the main points of difference from the Linux coding > style are summarised here, but if anybody has anything else they think should > be included (or anything they disagree with in my summary) it would be handy > to know.White space: only put spaces inside outermost brackets of if/while/for. For example, "if ( (wibble & wombat) == 42 )". Comments: /* * Multi-line comments are formatted like this. * No trailing white space, even at the end of the first line. */ Top-of-file comments: see e.g., common/page_alloc.c for preferred style. Emacs style: it''s okay to put an Emacs style block at the end of files, e.g., as in common/page_alloc.c. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel