This fixes a compilation problem on 32 bit machines. Signed-off-by: Stefan Berger _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 26/4/07 04:36, "Stefan Berger" <stefanb@us.ibm.com> wrote:> This fixes a compilation problem on 32 bit machines. > > Signed-off-by: Stefan BergerWhat''s the issue? You''re better off keeping the GUEST_HANDLE_64() and getting rid of the compat acm stuff. As far as I can see, all your interfaces are *currently* 32/64-bit invariant. So the compat stuff can safely be removed and then you don''t need to continually keep it sync. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Stefan Berger
2007-Apr-26 10:49 UTC
Re: [Xen-devel] Re: [PATCH] [ACM] Comilation fix for 32 bit
xen-devel-bounces@lists.xensource.com wrote on 04/26/2007 02:50:49 AM:> On 26/4/07 04:36, "Stefan Berger" <stefanb@us.ibm.com> wrote: > > > This fixes a compilation problem on 32 bit machines. > > > > Signed-off-by: Stefan Berger > > What''s the issue?It does not compile on 32bit because of those 4 lines. 64bit is fine.> > You''re better off keeping the GUEST_HANDLE_64() and getting rid of the > compat acm stuff. As far as I can see, all your interfaces are*currently*> 32/64-bit invariant. So the compat stuff can safely be removed and thenyou> don''t need to continually keep it sync.I was going to ask you about this. I am writing on a patch that puts all the ACM hypercall structures into a union. I am wondering what the compat stuff is for (xen/common/compat) and what the criterion is for needing this compat code. Stefan> > -- Keir > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2007-Apr-26 10:55 UTC
Re: [Xen-devel] Re: [PATCH] [ACM] Comilation fix for 32 bit
On 26/4/07 11:49, "Stefan Berger" <stefanb@us.ibm.com> wrote:>> > You''re better off keeping the GUEST_HANDLE_64() and getting rid of the >> > compat acm stuff. As far as I can see, all your interfaces are *currently* >> > 32/64-bit invariant. So the compat stuff can safely be removed and then you >> > don''t need to continually keep it sync. > > I was going to ask you about this. I am writing on a patch that puts all the > ACM hypercall structures into a union. I am wondering what the compat stuff is > for (xen/common/compat) and what the criterion is for needing this compat > code. >If you have structures that differ in layout in 32-bit mode vs. 64-bit mode then you need a compat shim when running 32-bit dom0 on 64-bit Xen (which we support doing nowadays). Currently you have no such issues that I¹m aware of. You should be able to delete the compat stuff that is there currently with no problems. Is the build failure in Xen itself or in tools? I¹m sure it¹s easily fixed without needing to throw away the GUEST_HANDLE_64() usage. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Stefan Berger
2007-Apr-26 10:59 UTC
Re: [Xen-devel] Re: [PATCH] [ACM] Comilation fix for 32 bit
xen-devel-bounces@lists.xensource.com wrote on 04/26/2007 06:55:06 AM:> On 26/4/07 11:49, "Stefan Berger" <stefanb@us.ibm.com> wrote:> > You''re better off keeping the GUEST_HANDLE_64() and getting rid of the > > compat acm stuff. As far as I can see, all your interfaces are*currently*> > 32/64-bit invariant. So the compat stuff can safely be removed andthen you> > don''t need to continually keep it sync. > > I was going to ask you about this. I am writing on a patch that puts > all the ACM hypercall structures into a union. I am wondering what > the compat stuff is for (xen/common/compat) and what the criterion > is for needing this compat code.> If you have structures that differ in layout in 32-bit mode vs. 64- > bit mode then you need a compat shim when running 32-bit dom0 on 64- > bit Xen (which we support doing nowadays). Currently you have no > such issues that I?m aware of. You should be able to delete the > compat stuff that is there currently with no problems.Ok.> > Is the build failure in Xen itself or in tools? I?m sure it?s easily > fixed without needing to throw away the GUEST_HANDLE_64() usage.It does not build in Xen. Stefan> > -- Keir_______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel