The Domain ID is currently expected to fit in 3 digits. When doing extensive testing on SAVE/RESTORE I can easily get ID''s into the 4-digit range, which makes some of the formatting to get out of sync. Attached (trivial) patch extends the width to 5 digits (and changes some %-ns to %ns, as the ID for example is right justified, %-ns is left-justified, which didn''t look too good). I''m fine with this going into Xen-unstable only, as it''s not really of any functional importance - it just makes things look a bit tidier with large DOMID numbers. Signed off by: Mats Petersson <mats.petersson@amd.com>. -- Mats _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Otavio Salvador
2007-Apr-20 12:22 UTC
Re: [Xen-devel] [PATCH][XM] Extend width of ID to 5.
"Petersson, Mats" <Mats.Petersson@amd.com> writes:> Attached (trivial) patch extends the width to 5 digits (and changes some > %-ns to %ns, as the ID for example is right justified, %-ns is > left-justified, which didn''t look too good).The only thing it can mess is automated tests and routines that uses the fixed width and will need a fix after this patch gets in. -- Otavio Salvador O.S. Systems E-mail: otavio@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Petersson, Mats
2007-Apr-20 13:13 UTC
RE: [Xen-devel] [PATCH][XM] Extend width of ID to 5.
> -----Original Message----- > From: Otavio Salvador [mailto:otavio@ossystems.com.br] > Sent: 20 April 2007 13:22 > To: Petersson, Mats > Cc: xen-devel@lists.xensource.com > Subject: Re: [Xen-devel] [PATCH][XM] Extend width of ID to 5. > > "Petersson, Mats" <Mats.Petersson@amd.com> writes: > > > Attached (trivial) patch extends the width to 5 digits (and > changes some > > %-ns to %ns, as the ID for example is right justified, %-ns is > > left-justified, which didn''t look too good). > > The only thing it can mess is automated tests and routines that uses > the fixed width and will need a fix after this patch gets in.Yes, of course, but such scrips would also be broken when the numbers get too big to fit in the fields, so those scripts are already possibly broken. Any script that parses the output of a program (and wishes to remain functional after revisions of the software) should use flexible field parsing rather than column-grabbing, in my opinion. But it''s also why I suggested that it may go into unstable only, rather than into the near-release 3.0.5 tree. -- Mats> > -- > Otavio Salvador O.S. Systems > E-mail: otavio@ossystems.com.br http://www.ossystems.com.br > Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br > > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Otavio Salvador
2007-Apr-20 13:17 UTC
Re: [Xen-devel] [PATCH][XM] Extend width of ID to 5.
"Petersson, Mats" <Mats.Petersson@amd.com> writes:>> The only thing it can mess is automated tests and routines that uses >> the fixed width and will need a fix after this patch gets in. > > Yes, of course, but such scrips would also be broken when the numbers > get too big to fit in the fields, so those scripts are already possibly > broken. Any script that parses the output of a program (and wishes to > remain functional after revisions of the software) should use flexible > field parsing rather than column-grabbing, in my opinion.Sure, I agree completely with you while I also know that this kind of "not-so-well-written-script" exist ;-)> But it''s also why I suggested that it may go into unstable only, rather > than into the near-release 3.0.5 tree.Well, I just think that a note on release notes would solve that. -- Otavio Salvador O.S. Systems E-mail: otavio@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel