Takahashi Tomohiro
2007-Apr-11 07:48 UTC
[Xen-devel] [PATCH][RFC] Fix pygrub for IA64 support.
Hi, I made a patch that fixed pygrub for IA64 support. This patch purposes to support pygrub on IA64. I just do fix pygrub and add LiloConf.py. (since IA64 uses elilo.conf) The discussion point is elilo.conf path. I use "/efi/redhat/elilo.conf" But this is distributer specific(for example Redhat). Is any idea to fix this issue? Signed-off-by: Shinya Kuwamura <kuwa@jp.fujitsu.com> Signed-off-by: Tomohiro Takahashi <takatom@jp.fujitsu.com> Thanks, Tomohiro Takahashi. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Alex Williamson
2007-Apr-11 14:05 UTC
Re: [Xen-devel] [PATCH][RFC] Fix pygrub for IA64 support.
On Wed, 2007-04-11 at 16:48 +0900, Takahashi Tomohiro wrote:> Hi, > > I made a patch that fixed pygrub for IA64 support. > > This patch purposes to support pygrub on IA64. > I just do fix pygrub and add LiloConf.py. > (since IA64 uses elilo.conf) > > The discussion point is elilo.conf path. > I use "/efi/redhat/elilo.conf" > But this is distributer specific(for example Redhat). > Is any idea to fix this issue?> grubfile = None > for f in ("/boot/grub/menu.lst", "/boot/grub/grub.conf", > - "/grub/menu.lst", "/grub/grub.conf"): > + "/grub/menu.lst", "/grub/grub.conf", > + "/efi/redhat/elilo.conf"):This is a search path, so rather than favoring one distribution, at a minimum, I think we need to include a reasonable sampling of distributions. Therefore, I''d add /efi/debian/elilo.conf and /efi/SuSE/elilo.conf. We should probably add RedFlag too, but I''ve never tried it to know what their elilo path is. I''d guess it''s just "/efi/redflag/elilo.conf". Ubuntu also has an unofficial ia64 port, but I believe they use the same path as Debian. This obviously isn''t the optimal solution, but we should try for some fairness. Keir, all 3 of these patches are touching common code, so I''ll leave it to you to check these directly into xen-unstable.hg. Getting pygrub working on ia64 would be a really nice feature to have for 3.0.5, so please consider these before the fork. Thanks, Alex -- Alex Williamson HP Open Source & Linux Org. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Alex Williamson
2007-Apr-11 14:17 UTC
Re: [Xen-devel] [PATCH][RFC] Fix pygrub for IA64 support.
On Wed, 2007-04-11 at 08:05 -0600, Alex Williamson wrote:> On Wed, 2007-04-11 at 16:48 +0900, Takahashi Tomohiro wrote: > > Hi, > > > > I made a patch that fixed pygrub for IA64 support. > > > > This patch purposes to support pygrub on IA64. > > I just do fix pygrub and add LiloConf.py. > > (since IA64 uses elilo.conf) > > > > The discussion point is elilo.conf path. > > I use "/efi/redhat/elilo.conf" > > But this is distributer specific(for example Redhat). > > Is any idea to fix this issue? > > > grubfile = None > > for f in ("/boot/grub/menu.lst", "/boot/grub/grub.conf", > > - "/grub/menu.lst", "/grub/grub.conf"): > > + "/grub/menu.lst", "/grub/grub.conf", > > + "/efi/redhat/elilo.conf"): > > This is a search path, so rather than favoring one distribution, at a > minimum, I think we need to include a reasonable sampling of > distributions. Therefore, I''d add /efi/debian/elilo.conf > and /efi/SuSE/elilo.conf. We should probably add RedFlag too, but I''ve > never tried it to know what their elilo path is. I''d guess it''s just > "/efi/redflag/elilo.conf". Ubuntu also has an unofficial ia64 port, but > I believe they use the same path as Debian. This obviously isn''t the > optimal solution, but we should try for some fairness.Oops, I forgot gentoo. I''d guess they use /efi/gentoo/elilo.conf. Alex> Keir, all 3 of these patches are touching common code, so I''ll leave > it to you to check these directly into xen-unstable.hg. Getting pygrub > working on ia64 would be a really nice feature to have for 3.0.5, so > please consider these before the fork. Thanks, > > Alex >-- Alex Williamson HP Open Source & Linux Org. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel