Jan Beulich
2007-Apr-05 11:16 UTC
[Xen-devel] include/xen/xencomm.h''s copy_field_{to, from}_guest() (PPC, IA64)
While the header is only being used by PPC, aren''t these two macros broken, i.e. shouldn''t the match the ia64 variants in using the structure base address from the handle and passing just _off as last argument to xencomm_copy_...()? Also, what is the reason for ia64 to cook its own rather than including the shared one? Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Isaku Yamahata
2007-Apr-06 02:06 UTC
Re: [Xen-devel] include/xen/xencomm.h''s copy_field_{to, from}_guest() (PPC, IA64)
On Thu, Apr 05, 2007 at 12:16:38PM +0100, Jan Beulich wrote:> While the header is only being used by PPC, aren''t these two macros broken, > i.e. shouldn''t the match the ia64 variants in using the structure base address > from the handle and passing just _off as last argument to xencomm_copy_...()? > > Also, what is the reason for ia64 to cook its own rather than including the > shared one?The ia64 xencomm development stragety was that adopt xencomm first, then consolidate it. But the consolication hasn''t been achieved yet. The PPC developers kindly arranged the common code already so that the rest task is left to the IA64 developers. However the task seems to be low priority. (Others may have different thoughts, though) Do you think it''s important or want to do it? -- yamahata _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel