Hi, Keir, vPIC has a private lock, but there''s no acquisition in the injection path. This should be a potential issue for change on IRR. Then the assertion (ASSERT(vpic_is_locked(vpic)) is likely to be failed within vpic_irq_negative_edge if debug option is enabled. Is anything missing here? Thanks, Kevin _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 29/3/07 03:39, "Tian, Kevin" <kevin.tian@intel.com> wrote:> Hi, Keir, > vPIC has a private lock, but there''s no acquisition in the > injection > path. This should be a potential issue for change on IRR. Then the > assertion (ASSERT(vpic_is_locked(vpic)) is likely to be failed within > vpic_irq_negative_edge if debug option is enabled. Is anything > missing here?No, there actually isn''t a private vPIC lock any more. If you look at the top of the vpic.c file you''ll see that the ''vpic lock'' is actually an alias for the generic irq_lock. This is always acquired by the caller of vpic_irq_negative_edge(). -- Keir> Thanks, > Kevin_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
>From: Keir Fraser [mailto:Keir.Fraser@cl.cam.ac.uk] >Sent: 2007年3月29日 15:34 > >On 29/3/07 03:39, "Tian, Kevin" <kevin.tian@intel.com> wrote: > >> Hi, Keir, >> vPIC has a private lock, but there''s no acquisition in the >> injection >> path. This should be a potential issue for change on IRR. Then the >> assertion (ASSERT(vpic_is_locked(vpic)) is likely to be failed within >> vpic_irq_negative_edge if debug option is enabled. Is anything >> missing here? > >No, there actually isn''t a private vPIC lock any more. If you look at the >top of the vpic.c file you''ll see that the ''vpic lock'' is actually an alias >for the generic irq_lock. This is always acquired by the caller of >vpic_irq_negative_edge(). > > -- Keir >Oh, yes, my mistake on position of parenthesis. :-) Thanks Kevin _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel