Masaki Kanno
2007-Mar-26 06:16 UTC
[Xen-devel] [PATCH] [Bug 933] Fix the xm mem-max command
Hi,
I fixed the Xen bugzilla 933 and other bug.
http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=933
BTW, I tested the xm mem-max command with attached patch.
The "maxmem" and the "memory" were changed as follows by the
xm mem-max command. Is the result specification? or
bug? I thought that the result is bug, so I tried to remove
the line of "self.info[''memory_dynamic_max''] = limit *
MiB"
in setMemoryMaximum(). As the result, only the "maxmem" was
changed by the xm mem-max command. Am I right?
# xm new /xen/vm1.conf
Using config file "/xen/vm1.conf".
# xm list --long vm1 | grep mem
(maxmem 384)
(memory 256)
(shadow_memory 0)
# xm mem-max vm1 512
# xm list --long vm1 | grep mem
(maxmem 512)
(memory 512)
(shadow_memory 0)
Signed-off-by: Masaki Kanno <kanno.masaki@jp.fujitsu.com>
Best regards,
Kan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Ewan Mellor
2007-Mar-26 13:04 UTC
Re: [Xen-devel] [PATCH] [Bug 933] Fix the xm mem-max command
On Mon, Mar 26, 2007 at 03:16:55PM +0900, Masaki Kanno wrote: Content-Description: Mail message body> Hi, > > I fixed the Xen bugzilla 933 and other bug. > http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=933Applied, thank you.> BTW, I tested the xm mem-max command with attached patch. > The "maxmem" and the "memory" were changed as follows by the > xm mem-max command. Is the result specification? or > bug? I thought that the result is bug, so I tried to remove > the line of "self.info[''memory_dynamic_max''] = limit * MiB" > in setMemoryMaximum(). As the result, only the "maxmem" was > changed by the xm mem-max command. Am I right?Yes, I think you are right -- only the static_max value should be set. I''ll fix this -- thanks. Ewan. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel