Brendan Cully
2007-Mar-16 21:23 UTC
[Xen-devel] [PATCH] Fix build when bcc is not installed
# HG changeset patch
# User Brendan Cully <brendan@cs.ubc.ca>
# Date 1174080142 25200
# Node ID 0712e96990851f278a2a27ef7f15b09bbff050c5
# Parent b6272addce8cd744e31a666672fa38bf5b27ffb3
Fix build when bcc is not installed
diff -r b6272addce8c -r 0712e9699085 tools/firmware/Makefile
--- a/tools/firmware/Makefile Fri Mar 16 13:57:41 2007 -0700
+++ b/tools/firmware/Makefile Fri Mar 16 14:22:22 2007 -0700
@@ -14,7 +14,7 @@ SUBDIRS += hvmloader
.PHONY: all
all:
- @set -e; if [ $$((`bcc -v 2>&1 | grep version | cut -d''
'' -f 3 | awk -F. ''{ printf "0x%02x%02x%02x", $$1,
$$2, $$3}''`)) -lt $$((0x00100e)) ] ; then \
+ @set -e; if [ $$((`( bcc -v 2>&1 | grep version || echo 0.0.0 ) | cut
-d'' '' -f 3 | awk -F. ''{ printf
"0x%02x%02x%02x", $$1, $$2, $$3}''`)) -lt $$((0x00100e)) ] ;
then \
echo "***********************************************************";
\
echo "Require dev86 package version >= 0.16.14 to build
firmware!"; \
echo "(visit http://www.cix.co.uk/~mayday for more information)"; \
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Keir Fraser
2007-Mar-16 22:06 UTC
Re: [Xen-devel] [PATCH] Fix build when bcc is not installed
How does your build fail without this patch? I tested building with no bcc and it works fine for me. Perhaps it depends on particular version of cut or awk? -- Keir On 16/3/07 21:23, "Brendan Cully" <brendan@cs.ubc.ca> wrote:> # HG changeset patch > # User Brendan Cully <brendan@cs.ubc.ca> > # Date 1174080142 25200 > # Node ID 0712e96990851f278a2a27ef7f15b09bbff050c5 > # Parent b6272addce8cd744e31a666672fa38bf5b27ffb3 > Fix build when bcc is not installed > > diff -r b6272addce8c -r 0712e9699085 tools/firmware/Makefile > --- a/tools/firmware/Makefile Fri Mar 16 13:57:41 2007 -0700 > +++ b/tools/firmware/Makefile Fri Mar 16 14:22:22 2007 -0700 > @@ -14,7 +14,7 @@ SUBDIRS += hvmloader > > .PHONY: all > all: > - @set -e; if [ $$((`bcc -v 2>&1 | grep version | cut -d'' '' -f 3 | awk -F. ''{ > printf "0x%02x%02x%02x", $$1, $$2, $$3}''`)) -lt $$((0x00100e)) ] ; then \ > + @set -e; if [ $$((`( bcc -v 2>&1 | grep version || echo 0.0.0 ) | cut -d'' '' > -f 3 | awk -F. ''{ printf "0x%02x%02x%02x", $$1, $$2, $$3}''`)) -lt > $$((0x00100e)) ] ; then \ > echo "***********************************************************"; \ > echo "Require dev86 package version >= 0.16.14 to build firmware!"; \ > echo "(visit http://www.cix.co.uk/~mayday for more information)"; \ > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Brendan Cully
2007-Mar-16 23:13 UTC
Re: [Xen-devel] [PATCH] Fix build when bcc is not installed
On Friday, 16 March 2007 at 22:06, Keir Fraser wrote:> How does your build fail without this patch? I tested building with no bcc > and it works fine for me. Perhaps it depends on particular version of cut or > awk?I don''t have the exact text on me, but it was something like syntax error: '''' How does your shell handle $((''''))? Mine doesn''t like it. I''d guess this is a case of ubuntu''s recent attempt to make sh more posix-pure.> On 16/3/07 21:23, "Brendan Cully" <brendan@cs.ubc.ca> wrote: > > > # HG changeset patch > > # User Brendan Cully <brendan@cs.ubc.ca> > > # Date 1174080142 25200 > > # Node ID 0712e96990851f278a2a27ef7f15b09bbff050c5 > > # Parent b6272addce8cd744e31a666672fa38bf5b27ffb3 > > Fix build when bcc is not installed > > > > diff -r b6272addce8c -r 0712e9699085 tools/firmware/Makefile > > +++ b/tools/firmware/Makefile Fri Mar 16 14:22:22 2007 -0700 > > @@ -14,7 +14,7 @@ SUBDIRS += hvmloader > > > > .PHONY: all > > all: > > - @set -e; if [ $$((`bcc -v 2>&1 | grep version | cut -d'' '' -f 3 | awk -F. ''{ > > printf "0x%02x%02x%02x", $$1, $$2, $$3}''`)) -lt $$((0x00100e)) ] ; then \ > > + @set -e; if [ $$((`( bcc -v 2>&1 | grep version || echo 0.0.0 ) | cut -d'' '' > > -f 3 | awk -F. ''{ printf "0x%02x%02x%02x", $$1, $$2, $$3}''`)) -lt > > $$((0x00100e)) ] ; then \ > > echo "***********************************************************"; \ > > echo "Require dev86 package version >= 0.16.14 to build firmware!"; \ > > echo "(visit http://www.cix.co.uk/~mayday for more information)"; \ > > > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xensource.com > > http://lists.xensource.com/xen-devel >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2007-Mar-16 23:16 UTC
Re: [Xen-devel] [PATCH] Fix build when bcc is not installed
On 16/3/07 23:13, "Brendan Cully" <brendan@cs.ubc.ca> wrote:> I don''t have the exact text on me, but it was something like > > syntax error: '''' > > How does your shell handle $((''''))? Mine doesn''t like it. I''d guess > this is a case of ubuntu''s recent attempt to make sh more posix-pure.Oh well. The fix seems straightforward and clear enough. I''ll stick it in. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel