On 8/3/07 10:10, "Jan Beulich" <jbeulich@novell.com> wrote:
> Is there a particular reason why page_set_owner(pg, NULL) is
> - not used in free_domheap_pages()?
It''s done in __alloc_domheap_pages() instead. Arguably moving it would
be
cleaner.
> - only used on pages 1 ... ((1 << order) - 1) in
__alloc_domheap_pages()?
Page 0 is done outside the loop, and writes directly to _domain for no
particularly good reason. I guess I implemented the first iteration outside
the loop to special-case initialisation of the tlbflush cpumask. Which
probably isn''t a very worthwhile optimisation, to be honest.
I''ll do a little cleanup here. It would certainly be sane to not have
random
domain pointers hanging around in freed pages.
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel