Jan Beulich
2007-Mar-07 14:56 UTC
[Xen-devel] [PATCH] netfront: adjust clearing of extras space
This fixes a latent bug if there will ever be a second kind of extra
defined.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
Index: head-2007-02-27/drivers/xen/netfront/netfront.c
==================================================================---
head-2007-02-27.orig/drivers/xen/netfront/netfront.c 2007-02-27
16:31:12.000000000 +0100
+++ head-2007-02-27/drivers/xen/netfront/netfront.c 2007-03-07
13:14:12.000000000 +0100
@@ -1317,7 +1317,7 @@ static int netif_poll(struct net_device
work_done = 0;
while ((i != rp) && (work_done < budget)) {
memcpy(rx, RING_GET_RESPONSE(&np->rx, i), sizeof(*rx));
- memset(extras, 0, sizeof(extras));
+ memset(extras, 0, sizeof(rinfo.extras));
err = xennet_get_responses(np, &rinfo, rp, &tmpq,
&pages_flipped);
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Herbert Xu
2007-Mar-08 03:12 UTC
Re: [Xen-devel] [PATCH] netfront: adjust clearing of extras space
Jan Beulich <jbeulich@novell.com> wrote:> This fixes a latent bug if there will ever be a second kind of extra > defined. > > Signed-off-by: Jan Beulich <jbeulich@novell.com>Thanks for catching this! This was a typo and it only ever worked by accident. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel