Stefan Berger
2007-Feb-27 17:19 UTC
[Xen-devel] [PATCH] [XEN] [ACM] Simplify the event channel scanning
This patch simplifies the scanning of a domain''s event channels considering that an ''ECS_UNBOUND'' event channel is not connected and can be skipped. Signed-off-by: Stefan Berger <stefanb@us.ibm.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2007-Feb-27 19:02 UTC
[Xen-devel] Re: [PATCH] [XEN] [ACM] Simplify the event channel scanning
On 27/2/07 17:19, "Stefan Berger" <stefanb@us.ibm.com> wrote:> This patch simplifies the scanning of a domain''s event channels > considering that an ''ECS_UNBOUND'' event channel is not connected and can > be skipped. > > Signed-off-by: Stefan Berger <stefanb@us.ibm.com>This code is still broken: you are checking only the first event-channel in each bucket. You need a double loop: the new inner loop should iterate from 0 to EVTCHNS_PER_BUCKET-1. ports = d->evtchn[bucket]; If ( ports == NULL ) break; for ( j = 0; j < EVTCHNS_PER_BUCKET; j++ ) .... process ports[j] .... -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel