Masaki Kanno
2007-Feb-19 09:15 UTC
[Xen-devel] [PATCH] Fix xm sched-sedf command to show a error message
Hi,
I tested the xm sched-sedf command with a wrong scheduler parameter.
It did not show a error message though it did not change the scheduler
parameter. (as follows)
# xm sched-sedf
Name ID Period(ms) Slice(ms) Lat(ms) Extra Weight
Domain-0 0 20.0 15.0 0.0 1 0
vm1 2 100.0 0.0 0.0 1 0
# xm sched-sedf vm1 -p 200.0
# xm sched-sedf
Name ID Period(ms) Slice(ms) Lat(ms) Extra Weight
Domain-0 0 20.0 15.0 0.0 1 0
vm1 2 100.0 0.0 0.0 1 0
I investigated the cause that the error message is not shown.
The cause is in sched_adjust(). sched_adjust() ignores the value that
sedf_adjust() returns, and always returns zero.
This patch fixes sched_adjust(). sched_adjust() receives the value that
sedf_adjust() returns, and returns it to do_domctl().
The test result of this patch is as follows.
# xm sched-sedf
Name ID Period(ms) Slice(ms) Lat(ms) Extra Weight
Domain-0 0 20.0 15.0 0.0 1 0
vm1 1 100.0 0.0 0.0 1 0
# xm sched-sedf vm1 -p 200.0
Error: (22, ''Invalid argument'')
Usage: xm sched-sedf <Domain> [options]
Get/set EDF parameters.
-p [MS], --period[=MS] Relative deadline(ms)
-s [MS], --slice[=MS] Worst-case execution time(ms). (slice <
period)
-l [MS], --latency[=MS] Scaled period (ms) when domain performs
heavy I/O
-e [FLAG], --extra[=FLAG] Flag (0 or 1) controls if domain can run
in extra time.
-w [FLOAT], --weight[=FLOAT] CPU Period/slice (do not set with
--period/--slice)
# xm sched-sedf
Name ID Period(ms) Slice(ms) Lat(ms) Extra Weight
Domain-0 0 20.0 15.0 0.0 1 0
vm1 1 100.0 0.0 0.0 1 0
Signed-off-by: Masaki Kanno <kanno.masaki@jp.fujitsu.com>
Best regards,
Kan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel