john.levon@sun.com
2007-Feb-09 14:04 UTC
[Xen-devel] [PATCH] If we''re building debug, show more guest information
# HG changeset patch # User john.levon@sun.com # Date 1171033428 28800 # Node ID 4708ec13626af36ce5440daa627149cb35e68fd2 # Parent e26e9fcc0e6e4cc0e8a3330611be984c17985743 If we''re building debug, show more guest information. Signed-off-by: John Levon <john.levon@sun.com> diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c --- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -67,14 +67,18 @@ static DEFINE_SPINLOCK(console_lock); * * L < lower_threshold : always logged * lower_threshold <= L < upper_threshold : rate-limited logging - * upper_threshold <= L : never logged + * upper_threshold < L : never logged * * Note, in the above algorithm, to disable rate limiting simply make * the lower threshold equal to the upper. */ #define XENLOG_UPPER_THRESHOLD 2 /* Do not print INFO and DEBUG */ #define XENLOG_LOWER_THRESHOLD 2 /* Always print ERR and WARNING */ +#ifdef NDEBUG #define XENLOG_GUEST_UPPER_THRESHOLD 2 /* Do not print INFO and DEBUG */ +#else +#define XENLOG_GUEST_UPPER_THRESHOLD 3 /* Do not print DEBUG */ +#endif #define XENLOG_GUEST_LOWER_THRESHOLD 0 /* Rate-limit ERR and WARNING */ /* * The XENLOG_DEFAULT is the default given to printks that _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2007-Feb-09 16:19 UTC
Re: [Xen-devel] [PATCH] If we''re building debug, show more guest information
It''s really not that hard to add loglvl=all guest_loglvl=all (or similar) to your boot command line when you want it (e.g., dev&test environments). K. On 9/2/07 2:04 pm, "john.levon@sun.com" <john.levon@sun.com> wrote:> # HG changeset patch > # User john.levon@sun.com > # Date 1171033428 28800 > # Node ID 4708ec13626af36ce5440daa627149cb35e68fd2 > # Parent e26e9fcc0e6e4cc0e8a3330611be984c17985743 > If we''re building debug, show more guest information. > > Signed-off-by: John Levon <john.levon@sun.com> > > diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c > --- a/xen/drivers/char/console.c > +++ b/xen/drivers/char/console.c > @@ -67,14 +67,18 @@ static DEFINE_SPINLOCK(console_lock); > * > * L < lower_threshold : always logged > * lower_threshold <= L < upper_threshold : rate-limited logging > - * upper_threshold <= L : never logged > + * upper_threshold < L : never logged > * > * Note, in the above algorithm, to disable rate limiting simply make > * the lower threshold equal to the upper. > */ > #define XENLOG_UPPER_THRESHOLD 2 /* Do not print INFO and DEBUG */ > #define XENLOG_LOWER_THRESHOLD 2 /* Always print ERR and WARNING */ > +#ifdef NDEBUG > #define XENLOG_GUEST_UPPER_THRESHOLD 2 /* Do not print INFO and DEBUG */ > +#else > +#define XENLOG_GUEST_UPPER_THRESHOLD 3 /* Do not print DEBUG */ > +#endif > #define XENLOG_GUEST_LOWER_THRESHOLD 0 /* Rate-limit ERR and WARNING */ > /* > * The XENLOG_DEFAULT is the default given to printks that > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
John Levon
2007-Feb-09 16:27 UTC
Re: [Xen-devel] [PATCH] If we''re building debug, show more guest information
On Fri, Feb 09, 2007 at 04:19:03PM +0000, Keir Fraser wrote:> It''s really not that hard to add loglvl=all guest_loglvl=all (or similar) to > your boot command line when you want it (e.g., dev&test environments).It''s hard enough when people don''t even know it exists. The whole point of a debug build is to debug things, and we''ve already had a lurking bug because it wasn''t turned on. In particular this was the decrease_reservation warning that''s threatened to become guest-visible in its comment. regards, john _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Pratt
2007-Feb-09 17:30 UTC
RE: [Xen-devel] [PATCH] If we''re building debug, show more guestinformation
> It''s really not that hard to add loglvl=all guest_loglvl=all (orsimilar)> to your boot command line when you want it (e.g., dev&testenvironments). I agree with John that changing the default is handy. Ian> K. > > On 9/2/07 2:04 pm, "john.levon@sun.com" <john.levon@sun.com> wrote: > > > # HG changeset patch > > # User john.levon@sun.com > > # Date 1171033428 28800 > > # Node ID 4708ec13626af36ce5440daa627149cb35e68fd2 > > # Parent e26e9fcc0e6e4cc0e8a3330611be984c17985743 > > If we''re building debug, show more guest information. > > > > Signed-off-by: John Levon <john.levon@sun.com> > > > > diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c > > --- a/xen/drivers/char/console.c > > +++ b/xen/drivers/char/console.c > > @@ -67,14 +67,18 @@ static DEFINE_SPINLOCK(console_lock); > > * > > * L < lower_threshold : always logged > > * lower_threshold <= L < upper_threshold : rate-limited logging > > - * upper_threshold <= L : never logged > > + * upper_threshold < L : never logged > > * > > * Note, in the above algorithm, to disable rate limiting simplymake> > * the lower threshold equal to the upper. > > */ > > #define XENLOG_UPPER_THRESHOLD 2 /* Do not print INFO andDEBUG> */ > > #define XENLOG_LOWER_THRESHOLD 2 /* Always print ERR andWARNING> */ > > +#ifdef NDEBUG > > #define XENLOG_GUEST_UPPER_THRESHOLD 2 /* Do not print INFO andDEBUG> */ > > +#else > > +#define XENLOG_GUEST_UPPER_THRESHOLD 3 /* Do not print DEBUG */ > > +#endif > > #define XENLOG_GUEST_LOWER_THRESHOLD 0 /* Rate-limit ERR andWARNING> */ > > /* > > * The XENLOG_DEFAULT is the default given to printks that > > > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xensource.com > > http://lists.xensource.com/xen-devel > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel