What is the purpose of adding arch/i386/kernel/alternative-xen.c, when the delta to native is a single line? Even more funny - arch/i386/kernel/intel_cacheinfo-xen.c doesn''t show any difference to native... Shouldn''t we try to reduce the number of such files, to ease maintaining them? Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Empty files can certainly be removed. Where there''s any diff at all, it''s a matter of taste whether we have separate files or ifdef XEN. -- Keir On 8/2/07 10:22, "Jan Beulich" <jbeulich@novell.com> wrote:> What is the purpose of adding arch/i386/kernel/alternative-xen.c, when the > delta to native is a single line? > > Even more funny - arch/i386/kernel/intel_cacheinfo-xen.c doesn''t show any > difference to native... > > Shouldn''t we try to reduce the number of such files, to ease maintaining them? > > Jan > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Thu, Feb 08, 2007 at 03:30:29PM +0000, Keir Fraser wrote:> Empty files can certainly be removed. Where there''s any diff at all, it''s a > matter of taste whether we have separate files or ifdef XEN.IMHO there are two many ways of cooking this egg. Patch vs Sparse + ifdef XEN vs separate file Finding the code can be kind of tricky, and working out the best way to implement a change seems to be a black art. Can''t this be simplified? (I''ll refrain from saxing axe sparse... oops, I didn''t) -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 9/2/07 1:16 am, "Horms" <horms@verge.net.au> wrote:> IMHO there are two many ways of cooking this egg. > > Patch vs Sparse + ifdef XEN vs separate file > > Finding the code can be kind of tricky, > and working out the best way to implement a change seems to be a black art. > > Can''t this be simplified? > > (I''ll refrain from saxing axe sparse... oops, I didn''t)Getting rid of the Linux tree from xen-unstable, and maintaining a full Linux repo in its place, is still planned for the next release. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Fri, Feb 09, 2007 at 04:12:16PM +0000, Keir Fraser wrote:> > > > On 9/2/07 1:16 am, "Horms" <horms@verge.net.au> wrote: > > > IMHO there are two many ways of cooking this egg. > > > > Patch vs Sparse + ifdef XEN vs separate file > > > > Finding the code can be kind of tricky, > > and working out the best way to implement a change seems to be a black art. > > > > Can''t this be simplified? > > > > (I''ll refrain from saxing axe sparse... oops, I didn''t) > > Getting rid of the Linux tree from xen-unstable, and maintaining a full > Linux repo in its place, is still planned for the next release.Great. -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel