Travis Betak
2007-Feb-01 03:09 UTC
[Xen-devel] [PATCH][SVM] Remove redundant update to V_TPR register
This patch removes the redundant update to the V_TPR VMCB field. The update is already done in the preceding call to vlapic_set_reg. This fix is for changeset 13762 in xen-unstable.hg Please apply. Signed-off-by: Travis Betak <travis.betak@amd.com> --- diff -r 588dd80b56b5 xen/arch/x86/hvm/svm/svm.c --- a/xen/arch/x86/hvm/svm/svm.c Wed Jan 31 19:37:44 2007 +0000 +++ b/xen/arch/x86/hvm/svm/svm.c Wed Jan 31 20:59:02 2007 -0600 @@ -1948,7 +1948,6 @@ static int mov_to_cr(int gpreg, int cr, case 8: vlapic_set_reg(vlapic, APIC_TASKPRI, ((value & 0x0F) << 4)); - vmcb->vintr.fields.tpr = value & 0x0F; break; default: _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2007-Feb-01 18:05 UTC
Re: [Xen-devel] [PATCH][SVM] Remove redundant update to V_TPR register
No, vlapic_set_reg() only writes to the software field. It doesn''t call out to update_vtpr(). -- Keir On 1/2/07 03:09, "Travis Betak" <travis.betak@amd.com> wrote:> This patch removes the redundant update to the V_TPR VMCB field. The > update is already done in the preceding call to vlapic_set_reg. > > This fix is for changeset 13762 in xen-unstable.hg > > Please apply. > > Signed-off-by: Travis Betak <travis.betak@amd.com> > > --- > > diff -r 588dd80b56b5 xen/arch/x86/hvm/svm/svm.c > --- a/xen/arch/x86/hvm/svm/svm.c Wed Jan 31 19:37:44 2007 +0000 > +++ b/xen/arch/x86/hvm/svm/svm.c Wed Jan 31 20:59:02 2007 -0600 > @@ -1948,7 +1948,6 @@ static int mov_to_cr(int gpreg, int cr, > > case 8: > vlapic_set_reg(vlapic, APIC_TASKPRI, ((value & 0x0F) << 4)); > - vmcb->vintr.fields.tpr = value & 0x0F; > break; > > default: > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Travis Betak
2007-Feb-01 19:28 UTC
Re: [Xen-devel] [PATCH][SVM] Remove redundant update to V_TPR register
On Thu, 1 Feb 2007, Keir Fraser wrote:> No, vlapic_set_reg() only writes to the software field. It doesn''t > call out to update_vtpr().Whoops! In a fit of tiredness I got vlapic_write() merged with vlapic_set_reg() in my head. Thanks! --travis _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel