Xen devel - Dec 2006 - [PATCH] qemu-dm monitor doesn''t support the quit command

Hi All,

It is natural that there is quit command in original QEMU. 
However, I don''t think that the HVM domain on Xen is necessary.
Because there is a possibility of shutting down GuestOS due to the mistake. 
I think that I should prohibit the quit command of qemu-dm. 

Thanks

--
Takanori Kasai

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Hi All,
> It is natural that there is quit command in original QEMU. 
> However, I don''t think that the HVM domain on Xen is necessary.
> Because there is a possibility of shutting down GuestOS due to the mistake.
> I think that I should prohibit the quit command of qemu-dm. 
So as to refuse the quit command, the patch was corrected. 
If there is any problem, please let me know.

Thanks

--
Takanori Kasai


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Hi All,

I sent the following patches the other day.
This patch makes qemu-dm monitor not support the quit command.
Because there is a possibility of shutting down HVM Domain by mistake.
We think that the HVM domain should shut down by xm shutdown/destroy command.
Could you apply this patch?


Thanks,

--
Takanori Kasai


----- Original Message ----- 
From: "Kasai Takanori" <kasai.takanori@jp.fujitsu.com>
To: "xen-devel" <xen-devel@lists.xensource.com>
Sent: Monday, December 25, 2006 10:47 AM
Subject: Re: [Xen-devel] [PATCH] qemu-dm monitor doesn''t support the
quit
command

> Hi All,
>
>> It is natural that there is quit command in original QEMU.
>> However, I don''t think that the HVM domain on Xen is
necessary.
>> Because there is a possibility of shutting down GuestOS due to the
mistake.
>> I think that I should prohibit the quit command of qemu-dm.
>
> So as to refuse the quit command, the patch was corrected.
> If there is any problem, please let me know.
>
> Thanks
>
> --
> Takanori Kasai

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

quit command is useful when we have no host console(e.g. qemu window on a remote
X). and it''s a normal exit that is different from xm destroy(by KILL
sig).

maybe we can change "q" to "quit" to avoid typo? or provide
confirm info?

BTW, "q" is most popular command when we debug qemu device model:)

On Wed, Jan 10, 2007 at 12:03:24PM +0900, Kasai Takanori
wrote:
> Hi All,
> 
> I sent the following patches the other day.
> This patch makes qemu-dm monitor not support the quit command.
> Because there is a possibility of shutting down HVM Domain by mistake.
> We think that the HVM domain should shut down by xm shutdown/destroy 
> command.
> Could you apply this patch?
> 
> 
> Thanks,
> 
> --
> Takanori Kasai
> 
> 
> ----- Original Message ----- 
> From: "Kasai Takanori" <kasai.takanori@jp.fujitsu.com>
> To: "xen-devel" <xen-devel@lists.xensource.com>
> Sent: Monday, December 25, 2006 10:47 AM
> Subject: Re: [Xen-devel] [PATCH] qemu-dm monitor doesn''t support
the quit
> command
> 
> 
> >Hi All,
> >
> >>It is natural that there is quit command in original QEMU.
> >>However, I don''t think that the HVM domain on Xen is
necessary.
> >>Because there is a possibility of shutting down GuestOS due to the 
> >>mistake.
> >>I think that I should prohibit the quit command of qemu-dm.
> >
> >So as to refuse the quit command, the patch was corrected.
> >If there is any problem, please let me know.
> >
> >Thanks
> >
> >--
> >Takanori Kasai
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

-- 
best rgds,
edwin

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Hi Edwin,

Thank you for reply.
> quit command is useful when we have no host console(e.g. qemu window on a 
> remote
> X). and it''s a normal exit that is different from xm destroy(by
KILL sig).
>
> maybe we can change "q" to "quit" to avoid typo? or
provide confirm info?
>
> BTW, "q" is most popular command when we debug qemu device
model:)
I understood the "quit" or "q" command was necessary for
debugging.
However, there is a possibility that the user shuts down the HVM domain by 
mistake.

Cannot you change "quit" or "q" to "quitdomain"?

Thanks,

--
Takanori Kasai
 



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Hi All,

I made the patch that changed it from quit or q to quitdomain. 
I think that the HVM domain can be prevented being shutted down 
by the mistake in this patch. 
If there is any problem, please let me know.
>> quit command is useful when we have no host console(e.g. qemu window on
a
>> remote
>> X). and it''s a normal exit that is different from xm
destroy(by KILL sig).
>>
>> maybe we can change "q" to "quit" to avoid typo? or
provide confirm info?
>>
>> BTW, "q" is most popular command when we debug qemu device
model:)
> 
> I understood the "quit" or "q" command was necessary
for debugging.
> However, there is a possibility that the user shuts down the HVM domain by 
> mistake.
> 
> Cannot you change "quit" or "q" to
"quitdomain"?
Thanks,

--
Takanori Kasai


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Kasai Takanori wrote:
> Hi All,
> 
> I made the patch that changed it from quit or q to quitdomain. I think 
> that the HVM domain can be prevented being shutted down by the mistake 
> in this patch. If there is any problem, please let me know.
It seems to me that this is just one more thing to get us further away
from the upstream QEMU tree and to me, that''s a bad thing. 
It''s not
this one patch in particular but once you get enough of these, it starts
getting hairy.

If you really thing the q command is poorly named, I think you should
make that case to the QEMU community.  It really isn''t a Xen specific
issue.

If this really is a problem for you, couldn''t you just keep the patch
around for your own use?  I haven''t seen anyone else complain of this
issue before so I''m not sure it will do anything but confuse other
people.

Regards,

Anthony Liguori
>>> quit command is useful when we have no host console(e.g. qemu
window
>>> on a remote
>>> X). and it''s a normal exit that is different from xm
destroy(by KILL
>>> sig).
>>>
>>> maybe we can change "q" to "quit" to avoid
typo? or provide confirm
>>> info?
>>>
>>> BTW, "q" is most popular command when we debug qemu
device model:)
>>
>> I understood the "quit" or "q" command was
necessary for debugging.
>> However, there is a possibility that the user shuts down the HVM 
>> domain by mistake.
>>
>> Cannot you change "quit" or "q" to
"quitdomain"?
> 
> Thanks,
> 
> -- 
> Takanori Kasai
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Hi Anthony,

Thank you for reply.
I want to achieve it by other methods.
>> I made the patch that changed it from quit or q to quitdomain. I think
>> that the HVM domain can be prevented being shutted down by the mistake
>> in this patch. If there is any problem, please let me know.
>
> It seems to me that this is just one more thing to get us further away
> from the upstream QEMU tree and to me, that''s a bad thing. 
It''s not
> this one patch in particular but once you get enough of these, it starts
> getting hairy.
I also think certainly like that.
> If you really thing the q command is poorly named, I think you should
> make that case to the QEMU community.  It really isn''t a Xen
specific issue.
It is natural that there is quit command in original QEMU.
 I do not think the agreement in the QEMU community.
> If this really is a problem for you, couldn''t you just keep the
patch
> around for your own use?  I haven''t seen anyone else complain of
this
> issue before so I''m not sure it will do anything but confuse other
people.
It was thought that it was necessary for the user''s using by the
operational
aspect.

Thanks,

--
Takanori Kasai



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel