Woller, Thomas
2006-Nov-30 21:16 UTC
[Xen-devel] [HVM][XENOPROFILE][PATCH] fix reversed test for mode function
Keir, This patch fixes incorrect logic in the recently added xenoprofile_get_mode() function. On HVM guests the !guest_mode(regs) test will always succeed, so move the is_hvm_vcpu() test first. This change allows modes other than 2 to be returned properly for xenoprofile for HVM guests. Signed-off-by: Tom Woller <thomas.woller@amd.com> Please apply to xen-unstable.hg. --Tom _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Dec-01 07:54 UTC
Re: [Xen-devel] [HVM][XENOPROFILE][PATCH] fix reversed test for mode function
On 30/11/06 9:16 pm, "Woller, Thomas" <thomas.woller@amd.com> wrote:> This patch fixes incorrect logic in the recently added > xenoprofile_get_mode() function. > On HVM guests the !guest_mode(regs) test will always succeed, so move > the is_hvm_vcpu() test first. > This change allows modes other than 2 to be returned properly for > xenoprofile for HVM guests. > > Signed-off-by: Tom Woller <thomas.woller@amd.com> > Please apply to xen-unstable.hg.This is wrong. The actual problem is that you should be passing guest_cpu_user_regs() to xenoprofile_get_mode(). I''ll fix that. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel