John Levon
2006-Oct-31 15:26 UTC
[Xen-devel] [PATCH] Stop enforcing -g for some of the tools.
# HG changeset patch # User john.levon@sun.com # Date 1162306981 28800 # Node ID 751794d972d79f1a2db4d6cee2df06bc88c51051 # Parent 48c0b3276b21492477df6c4c430c793e2afefbd4 Stop enforcing -g for some of the tools. Signed-off-by: John Levon <john.levon@sun.com> diff --git a/tools/console/Makefile b/tools/console/Makefile --- a/tools/console/Makefile +++ b/tools/console/Makefile @@ -5,7 +5,7 @@ DAEMON_INSTALL_DIR = /usr/sbin DAEMON_INSTALL_DIR = /usr/sbin CLIENT_INSTALL_DIR = /usr/$(LIBDIR)/xen/bin -CFLAGS += -Werror -g +CFLAGS += -Werror CFLAGS += -I $(XEN_LIBXC) CFLAGS += -I $(XEN_XENSTORE) diff --git a/tools/xenmon/Makefile b/tools/xenmon/Makefile --- a/tools/xenmon/Makefile +++ b/tools/xenmon/Makefile @@ -15,7 +15,7 @@ include $(XEN_ROOT)/tools/Rules.mk sbindir=/usr/sbin -CFLAGS += -Werror -g +CFLAGS += -Werror CFLAGS += -I $(XEN_XC) CFLAGS += -I $(XEN_LIBXC) LDFLAGS += -L $(XEN_LIBXC) diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile --- a/tools/xenstore/Makefile +++ b/tools/xenstore/Makefile @@ -6,7 +6,7 @@ MINOR = 0 MINOR = 0 PROFILE=#-pg -BASECFLAGS=-Wall -g -Werror +BASECFLAGS=-Werror # Make gcc generate dependencies. BASECFLAGS += -Wp,-MD,.$(@F).d PROG_DEP = .*.d _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Akio Takebe
2006-Nov-01 05:33 UTC
Re: [Xen-devel] [PATCH] Stop enforcing -g for some of the tools.
Hi, John I have small questions. The following option is written in $(XEN_ROOT)/Config.mk. ====================ifneq ($(debug),y) CFLAGS += -DNDEBUG else CFLAGS += -g endif ==================== So I think tools is compiled with -g by default if your patch is applied. Am I right?>diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile >--- a/tools/xenstore/Makefile >+++ b/tools/xenstore/Makefile >@@ -6,7 +6,7 @@ MINOR = 0 > MINOR = 0 > > PROFILE=#-pg >-BASECFLAGS=-Wall -g -Werror >+BASECFLAGS=-Werror > # Make gcc generate dependencies. > BASECFLAGS += -Wp,-MD,.$(@F).d > PROG_DEP = .*.dWhy do you remove -Wall? Best Regards, Akio Takebe _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Nov-01 07:38 UTC
Re: [Xen-devel] [PATCH] Stop enforcing -g for some of the tools.
On 1/11/06 5:33 am, "Akio Takebe" <takebe_akio@jp.fujitsu.com> wrote:> So I think tools is compiled with -g by default if your patch is applied. > Am I right?If debug=y, yes.> Why do you remove -Wall?It''s picked up from Config.mk. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel