thr3ads.net - Xen devel - [Xen-devel] [PATCH] [XM-TEST] Fix xm-test suite for x86-64 [Oct 2006]

If this information is useful, please help other people find it:
Share via:

Stefan Berger

2006-Oct-27 20:35 UTC

[Xen-devel] [PATCH] [XM-TEST] Fix xm-test suite for x86-64

This patch fixes the xm-test suite to allow building the buildroot
environment for x86-64. I had to disable hping2 in the configuration for
x86-64 since that package does not build without applying a patch to it.
So all hping2-related tests will fail now.
The problem is that I don''t know how to step into the buildroot
buildprocess and apply that patch for it.
http://www.redhat.com/archives/fedora-extras-commits/2005-February/msg00263.html

Signed-off-by: Stefan Berger <stefanb@us.ibm.com>




_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Tony Breeds

2006-Oct-28 04:34 UTC

head link

Re: [Xen-devel] [PATCH] [XM-TEST] Fix xm-test suite for x86-64

On Fri, Oct 27, 2006 at 04:35:00PM -0400, Stefan Berger wrote:
Hi Stefan
> This patch fixes the xm-test suite to allow building the buildroot
> environment for x86-64. 
It looks to me that this patch breaks powerpc.  When you rename uClibc
-> uClibc-i386 can you also clone it to create uClibc-powerpc?
>                         I had to disable hping2 in the configuration for
> x86-64 since that package does not build without applying a patch to it.
> So all hping2-related tests will fail now.Out of curiosity, What does the new x86_64 config do (other than disable
hping)?
> The problem is that I don''t know how to step into the buildroot
> buildprocess and apply that patch for it.
>
http://www.redhat.com/archives/fedora-extras-commits/2005-February/msg00263.html
It looks to me in tools/xm-test/ramdisk/patches/buildroot/patches
There is a patch that creates the makefile responsile for building
hping.

Could you not:
 a) Place the patch in that message in the patches dir
 b) modify the target that extracts the hping archive, to apply the
    patch?

Perhaps (untested):
---
$(HPING_DIR)/.source: $(DL_DIR)/$(HPING_TBALL)
       tar xzf $(DL_DIR)/$(HPING_TBALL) -C $(BUILD_DIR)
       [ $(BR_ARCH) -eq "x86_64" ] && patch -p1 -i
$(DL_DIR)/../patches/x86_64/hping.patch
       touch $(HPING_DIR)/.source
---

Would get you closer?

Yours Tony

   linux.conf.au       http://linux.conf.au/ || http://lca2007.linux.org.au/
   Jan 15-20 2007      The Australian Linux Technical Conference!


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Stefan Berger

2006-Oct-28 15:00 UTC

head link

Re: [Xen-devel] [PATCH] [XM-TEST] Fix xm-test suite for x86-64

Tony Breeds <tony@bakeyournoodle.com> wrote on 10/28/2006 12:34:01 AM:
> On Fri, Oct 27, 2006 at 04:35:00PM -0400, Stefan Berger wrote:
> Hi Stefan
> 
> > This patch fixes the xm-test suite to allow building the buildroot
> > environment for x86-64. 
> 
> It looks to me that this patch breaks powerpc.  When you rename uClibc
> -> uClibc-i386 can you also clone it to create uClibc-powerpc?
Did the uClibc really compiled/work for powerpc before? The 
''TARGET_i386=y'' is set in that common uClibc cnfig file.
> 
> >                         I had to disable hping2 in the configuration 
for> > x86-64 since that package does not build without applying a patch to 
it.> > So all hping2-related tests will fail now.
> Out of curiosity, What does the new x86_64 config do (other than disable
> hping)?
I tried  building the buildroot environment for x86-64 using the same as 
the i386 configuration. Unfortunatley the uClibc version that''s being 
downloaded for i386 does not compile for x86-64 due to a missing file in 
an x86-64 directory, so I switched it to use a snapshot of a given date.
> 
> > The problem is that I don''t know how to step into the
buildroot
> > buildprocess and apply that patch for it.
> > http://www.redhat.com/archives/fedora-extras-commits/2005-
> February/msg00263.html
> 
> It looks to me in tools/xm-test/ramdisk/patches/buildroot/patches
> There is a patch that creates the makefile responsile for building
> hping.
> 
> Could you not:
>  a) Place the patch in that message in the patches dir
>  b) modify the target that extracts the hping archive, to apply the
>     patch?
> 
> Perhaps (untested):
> ---
> $(HPING_DIR)/.source: $(DL_DIR)/$(HPING_TBALL)
>        tar xzf $(DL_DIR)/$(HPING_TBALL) -C $(BUILD_DIR)
>        [ $(BR_ARCH) -eq "x86_64" ] && patch -p1 -i
$(DL_DIR)/..
> /patches/x86_64/hping.patch
>        touch $(HPING_DIR)/.source
> ---
> 
> Would get you closer?
I will have a  look.

  Stefan
> 
> Yours Tony
> 
>    linux.conf.au       http://linux.conf.au/ || 
http://lca2007.linux.org.au/>    Jan 15-20 2007      The Australian Linux Technical Conference!
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Tony Breeds

2006-Oct-30 03:17 UTC

head link

Re: [Xen-devel] [PATCH] [XM-TEST] Fix xm-test suite for x86-64

On Sat, Oct 28, 2006 at 11:00:41AM -0400, Stefan Berger wrote:

Hi Stefan,
	Sorry for the delay in replying.  To be honnest I know that
uClibc works but I was unsure why, so I had to get access to a machine
I could investigate on.
> Did the uClibc really compiled/work for powerpc before? The 
> ''TARGET_i386=y'' is set in that common uClibc cnfig file.
Yes, thats correct but toolchain/uClibc/uclibc.mk overrides the TARGET
based on BR2_ARCH, which is correctly handels for native or cross
compiles.
> I tried  building the buildroot environment for x86-64 using the same as 
> the i386 configuration. Unfortunatley the uClibc version that''s
being
> downloaded for i386 does not compile for x86-64 due to a missing file in 
> an x86-64 directory, so I switched it to use a snapshot of a given date.
OK thanks.  It''s a shame that uClibc 0.9.28 doesn''t work on
x86_64.

Yours Tony

   linux.conf.au       http://linux.conf.au/ || http://lca2007.linux.org.au/
   Jan 15-20 2007      The Australian Linux Technical Conference!


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Stefan Berger

2006-Oct-30 14:44 UTC

head link

Re: [Xen-devel] [PATCH] [XM-TEST] Fix xm-test suite for x86-64

xen-devel-bounces@lists.xensource.com wrote on 10/29/2006 10:17:43 PM:
> On Sat, Oct 28, 2006 at 11:00:41AM -0400, Stefan Berger wrote:
> 
> Hi Stefan,
>    Sorry for the delay in replying.  To be honnest I know that
> uClibc works but I was unsure why, so I had to get access to a machine
> I could investigate on.
> 
> > Did the uClibc really compiled/work for powerpc before? The 
> > ''TARGET_i386=y'' is set in that common uClibc cnfig
file.
> 
> Yes, thats correct but toolchain/uClibc/uclibc.mk overrides the TARGET
> based on BR2_ARCH, which is correctly handels for native or cross
> compiles.
I have changed the xm-test/ramdisk/Makefile.am to look like this now. With 
this only x86-64 so far gets its own config for the uClibc.

-                cp configs/uClibc 
$(BR_SRC)/toolchain/uClibc/uClibc.config
+                if [ $(BR_ARCH) == "x86_64" ]; then \
+                                cp configs/uClibc-$(BR_ARCH)         \
+ $(BR_SRC)/toolchain/uClibc/uClibc.config; \
+                else \
+                                cp configs/uClibc         \
+ $(BR_SRC)/toolchain/uClibc/uClibc.config; \
+                fi

Is this better?
> 
> > I tried  building the buildroot environment for x86-64 using the same 
as > > the i386 configuration. Unfortunatley the uClibc version
that''s being
> > downloaded for i386 does not compile for x86-64 due to a missing file 
in > > an x86-64 directory, so I switched it to use a snapshot of a given 
date.> 
> OK thanks.  It''s a shame that uClibc 0.9.28 doesn''t work
on x86_64.
> I had encountered this error here:

http://bugs.busybox.net/bug_view_advanced_page.php?bug_id=523

And thanks on the hint on how to patch hping2. It works now - at least for 
x86-64.

  Stefan
> Yours Tony
> 
>    linux.conf.au       http://linux.conf.au/ || 
http://lca2007.linux.org.au/>    Jan 15-20 2007      The Australian Linux Technical Conference!
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Tony Breeds

2006-Oct-31 00:42 UTC

head link

Re: [Xen-devel] [PATCH] [XM-TEST] Fix xm-test suite for x86-64

On Mon, Oct 30, 2006 at 09:44:52AM -0500, Stefan Berger wrote:
 > I have changed the xm-test/ramdisk/Makefile.am to look like this now. With 
> this only x86-64 so far gets its own config for the uClibc.
> 
> -                cp configs/uClibc $(BR_SRC)/toolchain/uClibc/uClibc.config
> +                if [ $(BR_ARCH) == "x86_64" ]; then \
> +                                cp configs/uClibc-$(BR_ARCH)         \
> + $(BR_SRC)/toolchain/uClibc/uClibc.config; \
> +                else \
> +                                cp configs/uClibc         \
> + $(BR_SRC)/toolchain/uClibc/uClibc.config; \
> +                fi
> 
> Is this better?
Personally I prefer your original approach.  Sure it creates duplicate
data files (as i386 and powerpc uClibc are the same) but it follows the
buildroot precident, and allows for changing configs based on the arch
without modifying the Makefiles.
 > http://bugs.busybox.net/bug_view_advanced_page.php?bug_id=523
Bugger.  I wonder what the timeframe is for the next uClibc release.
 > And thanks on the hint on how to patch hping2. It works now - at least for 
> x86-64.
Glad it helped.

Yours Tony

   linux.conf.au       http://linux.conf.au/ || http://lca2007.linux.org.au/
   Jan 15-20 2007      The Australian Linux Technical Conference!


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Xen devel - Oct 2006 - [PATCH] [XM-TEST] Fix xm-test suite for x86-64

[Xen-devel] [PATCH] [XM-TEST] Fix xm-test suite for x86-64

Re: [Xen-devel] [PATCH] [XM-TEST] Fix xm-test suite for x86-64

Re: [Xen-devel] [PATCH] [XM-TEST] Fix xm-test suite for x86-64

Re: [Xen-devel] [PATCH] [XM-TEST] Fix xm-test suite for x86-64

Re: [Xen-devel] [PATCH] [XM-TEST] Fix xm-test suite for x86-64

Re: [Xen-devel] [PATCH] [XM-TEST] Fix xm-test suite for x86-64