We have a build issue when building for PAE guests - the kernel symbol __supported_pte_mask is not exported on any of the kernels of interest (2.6.5, 2.6.9, 2.6.16..) and is used in the function: pfn_pte_ma (maddr.h) . In this scenario, this function is used only by the front-end drivers that are running within the unmodified guests. Would it make sense to have an implementation of the function pfn_pte_ma() only for consumption by the PV front-end driver modules that does not depend on the __supported_pte_mask variable. Regards, K. Y _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 19/10/06 15:06, "Ky Srinivasan" <ksrinivasan@novell.com> wrote:> We have a build issue when building for PAE guests - the kernel symbol > __supported_pte_mask is not exported on any of the kernels of interest (2.6.5, > 2.6.9, 2.6.16..) and is used in the function: pfn_pte_ma (maddr.h) . In this > scenario, this function is used only by the front-end drivers that are running > within the unmodified guests. Would it make sense to have an implementation > of the function pfn_pte_ma() only for consumption by the PV front-end driver > modules that does not depend on the __supported_pte_mask variable.Sounds like the only option. I suggest a module-private version of the pte_mask which defaults to only a limited subset of PTE flags. Optionally you could add in _PAGE_NX if CPUID/EFER allows it. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Thanks. I will send you a patch. Regards, K. Y>>> On Thu, Oct 19, 2006 at 10:12 AM, in message<C15D4675.2CE6%Keir.Fraser@cl.cam.ac.uk>, Keir Fraser <Keir.Fraser@cl.cam.ac.uk> wrote:> > > On 19/10/06 15:06, "Ky Srinivasan" <ksrinivasan@novell.com> wrote: > >> We have a build issue when building for PAE guests - the kernel symbol >> __supported_pte_mask is not exported on any of the kernels of interest > (2.6.5, >> 2.6.9, 2.6.16..) and is used in the function: pfn_pte_ma (maddr.h) . In > this >> scenario, this function is used only by the front- end drivers that are > running >> within the unmodified guests. Would it make sense to have an implementation >> of the function pfn_pte_ma() only for consumption by the PV front- end driver >> modules that does not depend on the __supported_pte_mask variable. > > Sounds like the only option. I suggest a module- private version of the > pte_mask which defaults to only a limited subset of PTE flags. Optionally > you could add in _PAGE_NX if CPUID/EFER allows it. > > -- Keir_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 19/10/06 15:15, "Ky Srinivasan" <ksrinivasan@novell.com> wrote:> Thanks. I will send you a patch. > > Regards, > > K. YLogically this belongs in your external patch, as this is a compat issue. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel