HVM MMIO/PIO fixes and cleanups: 1) fix MMIO/PIO cross page boundary copy for MOVS and OUTS/INS handling. 2) clean up send_mmio_req/send_pio_req interface. 3) clean up handle_mmio. Singed-off-by: Xin Li <xin.b.li@intel.com> Singed-off-by: Xiaowei Yang <xiaowei.yang@intel.com> Signed-off-by: Eddie Dong <eddie.dong@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Broken DPRINTK in INSTR_MOVS case of handle_mmio() shows this was never tested with a debug build. Please do that in future. -- Keir On 18/10/06 12:48, "Li, Xin B" <xin.b.li@intel.com> wrote:> HVM MMIO/PIO fixes and cleanups: > 1) fix MMIO/PIO cross page boundary copy for MOVS and OUTS/INS handling. > 2) clean up send_mmio_req/send_pio_req interface. > 3) clean up handle_mmio. > > Singed-off-by: Xin Li <xin.b.li@intel.com> > Singed-off-by: Xiaowei Yang <xiaowei.yang@intel.com> > Signed-off-by: Eddie Dong <eddie.dong@intel.com>_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Oh, my fault! Thanks for fixing it! -Xin>-----Original Message----- >From: Keir Fraser [mailto:Keir.Fraser@cl.cam.ac.uk] >Sent: 2006年10月18日 22:14 >To: Li, Xin B; xen-devel@lists.xensource.com >Subject: Re: [Xen-devel] [PATCH] HVM MMIO/PIO fixes and cleanups > >Broken DPRINTK in INSTR_MOVS case of handle_mmio() shows this was never >tested with a debug build. Please do that in future. > > -- Keir > >On 18/10/06 12:48, "Li, Xin B" <xin.b.li@intel.com> wrote: > >> HVM MMIO/PIO fixes and cleanups: >> 1) fix MMIO/PIO cross page boundary copy for MOVS and >OUTS/INS handling. >> 2) clean up send_mmio_req/send_pio_req interface. >> 3) clean up handle_mmio. >> >> Singed-off-by: Xin Li <xin.b.li@intel.com> >> Singed-off-by: Xiaowei Yang <xiaowei.yang@intel.com> >> Signed-off-by: Eddie Dong <eddie.dong@intel.com> >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel