# HG changeset patch # User john.levon@sun.com # Date 1161091246 25200 # Node ID 0551e95306fac1e639d144a21b07a83388270422 # Parent 1a414db2ca7bc6386076f66ce07abd6e1e32ea04 Add a XEN_VENDORVERSION variable to allow additional text on top of the extra version. Signed-off-by: John Levon <john.levon@sun.com> diff --git a/xen/Makefile b/xen/Makefile --- a/xen/Makefile +++ b/xen/Makefile @@ -1,9 +1,10 @@ # This is the correct place to edit the build version. # All other places this is stored (eg. compile.h) should be autogenerated. -export XEN_VERSION = 3 -export XEN_SUBVERSION = 0 -export XEN_EXTRAVERSION ?= -unstable -export XEN_FULLVERSION = $(XEN_VERSION).$(XEN_SUBVERSION)$(XEN_EXTRAVERSION) +export XEN_VERSION = 3 +export XEN_SUBVERSION = 0 +export XEN_VENDORVERSION ?+export XEN_EXTRAVERSION ?= -unstable$(XEN_VENDORVERSION) +export XEN_FULLVERSION = $(XEN_VERSION).$(XEN_SUBVERSION)$(XEN_EXTRAVERSION) -include xen-version export BASEDIR := $(CURDIR) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 17/10/06 14:21, "John Levon" <levon@movementarian.org> wrote:> Add a XEN_VENDORVERSION variable to allow additional text on top of the extra > version. > > Signed-off-by: John Levon <john.levon@sun.com>Sounds like a bit of a XEN_EXTRAEXTRAVERSION. :-) Can''t you just redefine XEN_EXTRAVERSION? That doesn''t sound too onerous to me. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Tue, Oct 17, 2006 at 06:28:07PM +0100, Keir Fraser wrote:> > Add a XEN_VENDORVERSION variable to allow additional text on top of the extra > > version. > > > > Signed-off-by: John Levon <john.levon@sun.com> > > Sounds like a bit of a XEN_EXTRAEXTRAVERSION. :-) Can''t you just redefine > XEN_EXTRAVERSION? That doesn''t sound too onerous to me.I believe the idea was that you could always set XEN_VENDORVERSION without having to worry exactly what version is being set by Xen. That is, a prefix that is guaranteed never to be set by upstream. But it''s not particularly onerous, no. regards, john _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 17/10/06 18:35, "John Levon" <levon@movementarian.org> wrote:>> Sounds like a bit of a XEN_EXTRAEXTRAVERSION. :-) Can''t you just redefine >> XEN_EXTRAVERSION? That doesn''t sound too onerous to me. > > I believe the idea was that you could always set XEN_VENDORVERSION > without having to worry exactly what version is being set by Xen. That > is, a prefix that is guaranteed never to be set by upstream.I suppose that''s reasonable. The empty ''?='' assignment is not needed. I''ll take the one-line mod to XEN_EXTRAVERSION. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel