Xen devel - Oct 2006 - [PATCH] Don''t attempt to build kernels on Solaris.

# HG changeset patch
# User john.levon@sun.com
# Date 1161090501 25200
# Node ID f75a36bdfe9728f99ec81c9279725e47f9d7d14a
# Parent  d8e4ae663b2b03e76f2152b8846a067fc2911572
Don''t attempt to build kernels on Solaris.

Signed-off-by: John Levon <john.levon@sun.com>

diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -57,38 +57,46 @@ kernels: dist-kernels
 kernels: dist-kernels
 docs: dist-docs
 
+.PHONY: install-xen
+install-xen:
+	$(MAKE) -C xen install
+
+.PHONY: install-tools
+install-tools:
+	$(MAKE) -C tools install
+
+.PHONY: install-docs
+install-docs:
+	sh ./docs/check_pkgs && $(MAKE) -C docs install || true
+
+.PHONY: dev-docs
+dev-docs:
+	$(MAKE) -C docs dev-docs
+
 .PHONY: prep-kernels
 prep-kernels:
 	for i in $(XKERNELS) ; do $(MAKE) $$i-prep || exit 1; done
 
-.PHONY: install-xen
-install-xen:
-	$(MAKE) -C xen install
-
-.PHONY: install-tools
-install-tools:
-	$(MAKE) -C tools install
-
-.PHONY: install-kernels
-install-kernels:
+.PHONY: install-kernels install-kernels-$(XEN_OS)
+install-kernels-Linux:
 	for i in $(XKERNELS) ; do $(MAKE) $$i-install || exit 1; done
 
-.PHONY: install-docs
-install-docs:
-	sh ./docs/check_pkgs && $(MAKE) -C docs install || true
-
-.PHONY: dev-docs
-dev-docs:
-	$(MAKE) -C docs dev-docs
+install-kernels-SunOS:
+
+install-kernels: install-kernels-$(XEN_OS)
 
 # Build all the various kernels and modules
 .PHONY: kbuild
 kbuild: kernels
 
 # Delete the kernel build trees entirely
-.PHONY: kdelete
-kdelete:
+.PHONY: kdelete kdelete-$(XEN_OS)
+kdelete-Linux:
 	for i in $(XKERNELS) ; do $(MAKE) $$i-delete ; done
+
+kdelete-SunOS:
+
+kdelete: kdelete-$(XEN_OS)
 
 # Clean the kernel build trees
 .PHONY: kclean

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 17/10/06 14:09, "John Levon" <levon@movementarian.org> wrote:
> Don''t attempt to build kernels on Solaris.
> 
> Signed-off-by: John Levon <john.levon@sun.com>
Doesn''t empty XKERNELS variable get you this for free? I thought that
was
the point of moving KERNELS/XKERNELS to Linux.mk.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Tue, Oct 17, 2006 at 05:33:47PM +0100, Keir Fraser wrote:
> > Don''t attempt to build kernels on Solaris.
> > 
> > Signed-off-by: John Levon <john.levon@sun.com>
> 
> Doesn''t empty XKERNELS variable get you this for free? I thought
that was
> the point of moving KERNELS/XKERNELS to Linux.mk.
We need this as well because of things like:

	for i in $(XKERNELS) ; do $(MAKE) $$i-prep || exit 1; done

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 17/10/06 17:38, "John Levon" <levon@movementarian.org> wrote:
>> Doesn''t empty XKERNELS variable get you this for free? I
thought that was
>> the point of moving KERNELS/XKERNELS to Linux.mk.
> 
> We need this as well because of things like:
> 
> for i in $(XKERNELS) ; do $(MAKE) $$i-prep || exit 1; done
But bash can handle empty lists. If XKERNELS is empty the above should be a
no-op, right? Certainly seems to have that behaviour for me.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Tue, Oct 17, 2006 at 05:58:46PM +0100, Keir Fraser wrote:
> >> Doesn''t empty XKERNELS variable get you this for free? I
thought that was
> >> the point of moving KERNELS/XKERNELS to Linux.mk.
> > 
> > We need this as well because of things like:
> > 
> > for i in $(XKERNELS) ; do $(MAKE) $$i-prep || exit 1; done
> 
> But bash can handle empty lists. If XKERNELS is empty the above should be a
> no-op, right? Certainly seems to have that behaviour for me.
Ah. This patch obviously predates the "use bash for SHELL" one.
You''re
right, it''s not necessary, and can be dropped.

thanks
john

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel