>>> Gerd Hoffmann <kraxel@suse.de> 10/11/06 11:16 AM >>> >Jan Beulich wrote: >>> + uint32_t unused; /* alignment */ >> >> Could you use _pad[0-9]* here as is done elsewhere, so that scripts > >Fixed using "_attribute__((aligned (8)))" instead.If I remember right, we had complaints about such an approach already - public headers shouldn''t contain (unconditional) GNU-isms. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Gerd Hoffmann
2006-Oct-16 08:06 UTC
[Xen-devel] Re: [patch rfc 1/3] xen arch header rework.
Jan Beulich wrote:>>>> Gerd Hoffmann <kraxel@suse.de> 10/11/06 11:16 AM >>> >> Jan Beulich wrote: >>>> + uint32_t unused; /* alignment */ >>> Could you use _pad[0-9]* here as is done elsewhere, so that scripts >> Fixed using "_attribute__((aligned (8)))" instead. > > If I remember right, we had complaints about such an approach already - > public headers shouldn''t contain (unconditional) GNU-isms.Current patch adds one level of indirection for that, so the solaris guys can add something which works for sun cc. Latest version of the patch is here: http://www.suse.de/~kraxel/patches/kraxel-unstable-zweiblum-hg11751-quilt/learning-python.diff cheers, Gerd -- Gerd Hoffmann <kraxel@suse.de> http://www.suse.de/~kraxel/julika-dora.jpeg _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel