Xen devel - Oct 2006 - RE: [Xen-ia64-devel] [PATCH] Xen panics when domvti is destroyed

>-----Original Message-----
>From: Kouya SHIMURA [mailto:kouya@jp.fujitsu.com]
>Sent: 2006年10月11日 14:27
>To: Xu, Anthony
>Cc: xen-ia64-devel@lists.xensource.com
>Subject: RE: [Xen-ia64-devel] [PATCH] Xen panics when domvti is destroyed
>
>Hi Anthony,
>
>I think that vmx_final_setup_guest() is called asynchronously.
>Because the secondary vcpus are waken by IPI, not control panel.
>Actually we can observe the following log message asynchronously.
>(XEN) arch_boot_vcpu: vcpu 1 awaken 00000000046bc180!
You are right at this point.
>
>vmx_relinquish_vcpu_resources() is called after sched_destroy_domain().
>If the scheduler stops vcpus completely in sched_destroy_domain(),
>it might be OK. But it seems to be up to scheduler.
I''m not sure about this, 
But, if vcpus are not completely stopped before calling
vmx_relinquish_vcpu_resources,
That''s a big issue; vcpus may access some memories which have been
freed and may be
used by other guys.


Keir,

When free_vcpu_struct() is called, is it guaranteed that this vcpu is stopped
completely?

Thanks,
Anthony

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@lists.xensource.com
http://lists.xensource.com/xen-ia64-devel

On 11/10/06 08:34, "Xu, Anthony" <anthony.xu@intel.com> wrote:
> Keir,
> 
> When free_vcpu_struct() is called, is it guaranteed that this vcpu is
stopped
> completely?
Yes. domain_kill() calls domain_pause() which synchronously stops execution
of every VCPU. domain_kill() drops a ''master reference'' on the
domain, so
the destructors cannot run until domain_kill() has run.

 -- Keir



_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@lists.xensource.com
http://lists.xensource.com/xen-ia64-devel