Glauber de Oliveira Costa
2006-Oct-09 17:22 UTC
[Xen-devel] [PATCH] Sleeping with spinlock held
Hi, In drivers/xen/blkfront/blkfront.c, flush_scheduled_work(), that might sleep, is being called with a spinlock held, thus triggering a BUG. I think it''s safe to just poke it out from the locked region, as it seems to me we won''t be receiving any more work at this time. In case you agree, I''m attaching a simple patch that fix this. -- Glauber de Oliveira Costa Red Hat Inc. "Free as in Freedom" _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Glauber de Oliveira Costa
2006-Oct-09 19:30 UTC
[Xen-devel] [PATCH] Sleeping with spinlock held
Hi, In drivers/xen/blkfront/blkfront.c, flush_scheduled_work(), that might sleep, is being called with a spinlock held, thus triggering a BUG. I think it''s safe to just poke it out from the locked region, as it seems to me we won''t be receiving any more work at this time. In case you agree, I''m attaching a simple patch that fix this. -- Glauber de Oliveira Costa Red Hat Inc. "Free as in Freedom" _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 9/10/06 8:30 pm, "Glauber de Oliveira Costa" <gcosta@redhat.com> wrote:> In drivers/xen/blkfront/blkfront.c, flush_scheduled_work(), that might > sleep, is being called with a spinlock held, thus triggering a BUG. > I think it''s safe to just poke it out from the locked region, as it > seems to me we won''t be receiving any more work at this time. > > In case you agree, I''m attaching a simple patch that fix this.Already fixed in xen-unstable, but thanks! -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel