Isaku Yamahata
2006-Oct-03 05:06 UTC
[Xen-devel] [PATCH] make MAX_SKBUFF_ORDER page size independent
make MAX_SKBUFF_ORDER page size independent. Presumably the original value 4 comes from 64KB = (4KB << 4) which is ip packet maximum size. However page size is not always 4KB. e.g. IA64 default page size is 16KB. -- yamahata _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Tristan Gingold
2006-Oct-03 06:43 UTC
[Xen-devel] Re: [Xen-ia64-devel] [PATCH] make MAX_SKBUFF_ORDER page size independent
Le Mardi 03 Octobre 2006 07:06, Isaku Yamahata a écrit :> make MAX_SKBUFF_ORDER page size independent. > Presumably the original value 4 comes from 64KB = (4KB << 4) which is > ip packet maximum size. > However page size is not always 4KB. e.g. IA64 default page size is 16KB.I suppose it fixes the fedora bug ? I wonder if this patch works when pagesize is 64KB ? Maybe force 1 as the minimum value ? Tristan. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Oct-03 06:59 UTC
Re: [Xen-devel] Re: [Xen-ia64-devel] [PATCH] make MAX_SKBUFF_ORDER page size independent
On 3/10/06 7:43 am, "Tristan Gingold" <Tristan.Gingold@bull.net> wrote:> Le Mardi 03 Octobre 2006 07:06, Isaku Yamahata a écrit : >> make MAX_SKBUFF_ORDER page size independent. >> Presumably the original value 4 comes from 64KB = (4KB << 4) which is >> ip packet maximum size. >> However page size is not always 4KB. e.g. IA64 default page size is 16KB. > I suppose it fixes the fedora bug ? > > I wonder if this patch works when pagesize is 64KB ? Maybe force 1 as the > minimum value ?We want to move to the copying receive path as default asap by the way, you might want to check that it works with ia64 (boot a domU with extra Linux cmdline option "xennet.rx_copy" and check you get a boot message saying that a net device eth0 has been created with copying receive path). Also since our network interfaces now support scatter-gather (thanks to Herbert Xu) I expect to get rid of our special skbuff allocators, at least for oridnary alloc_skb and dev_alloc_skb calls. This should happen early in the 3.0.4 development cycle. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Tristan Gingold
2006-Oct-03 08:28 UTC
Re: [Xen-devel] Re: [Xen-ia64-devel] [PATCH] make MAX_SKBUFF_ORDER page size independent
Le Mardi 03 Octobre 2006 08:59, Keir Fraser a écrit :> On 3/10/06 7:43 am, "Tristan Gingold" <Tristan.Gingold@bull.net> wrote: > > Le Mardi 03 Octobre 2006 07:06, Isaku Yamahata a écrit : > >> make MAX_SKBUFF_ORDER page size independent. > >> Presumably the original value 4 comes from 64KB = (4KB << 4) which is > >> ip packet maximum size. > >> However page size is not always 4KB. e.g. IA64 default page size is > >> 16KB. > > > > I suppose it fixes the fedora bug ? > > > > I wonder if this patch works when pagesize is 64KB ? Maybe force 1 as > > the minimum value ? > > We want to move to the copying receive path as default asap by the way, you > might want to check that it works with ia64 (boot a domU with extra Linux > cmdline option "xennet.rx_copy" and check you get a boot message saying > that a net device eth0 has been created with copying receive path).This option has net yet been merged in xen-ia64-unstable.hg; I will try ASAP.> Also since our network interfaces now support scatter-gather (thanks to > Herbert Xu) I expect to get rid of our special skbuff allocators, at least > for oridnary alloc_skb and dev_alloc_skb calls. This should happen early in > the 3.0.4 development cycle.Good news. Tristan. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Isaku Yamahata
2006-Oct-03 09:22 UTC
Re: [Xen-devel] Re: [Xen-ia64-devel] [PATCH] make MAX_SKBUFF_ORDER page size independent
On Tue, Oct 03, 2006 at 08:43:34AM +0200, Tristan Gingold wrote:> Le Mardi 03 Octobre 2006 07:06, Isaku Yamahata a écrit : > > make MAX_SKBUFF_ORDER page size independent. > > Presumably the original value 4 comes from 64KB = (4KB << 4) which is > > ip packet maximum size. > > However page size is not always 4KB. e.g. IA64 default page size is 16KB. > I suppose it fixes the fedora bug ? > > I wonder if this patch works when pagesize is 64KB ? Maybe force 1 as the > minimum value ?fixed. -- yamahata _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Alex Williamson
2006-Oct-03 21:06 UTC
Re: [Xen-devel] Re: [Xen-ia64-devel] [PATCH] make MAX_SKBUFF_ORDER page size independent
On Tue, 2006-10-03 at 10:28 +0200, Tristan Gingold wrote:> Le Mardi 03 Octobre 2006 08:59, Keir Fraser a écrit : > > We want to move to the copying receive path as default asap by the way, you > > might want to check that it works with ia64 (boot a domU with extra Linux > > cmdline option "xennet.rx_copy" and check you get a boot message saying > > that a net device eth0 has been created with copying receive path). > This option has net yet been merged in xen-ia64-unstable.hg; I will try ASAP.Seems to work for me on xen-unstable.hg. I merged this code into xen-ia64-unstable.hg and had to make one little tweak to get it going there, but it looks good now. Thanks, Alex -- Alex Williamson HP Open Source & Linux Org. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel