Along with the blktap hardcoding of a major number. It has come to my attention that evtchn also hardcodes a minor number. Not so bad, but can later cause conflicts. evtchn uses the misc device to get its major number. This patch makes evtchn use a dynamic minor number instead. It also updates the code in tools to create the device node if udev fails. The tools now read the sysfs system to find the minor number needed. One thing that is missing though, in this patch, is the update to ./debugger/pdb/evtchn.ml, which still has the hard coded 201 as the minor. This calls evtchn_open which is a C function that creates the node if it doesn''t already exist. I don''t know much about Modula-2 but the major and minor probably don''t need to be passed in, and the C code can do the same thing as the tools do now. But I''ll let others decide on that. -- Steve Signed-off-by: Steven Rostedt <srostedt@redhat.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Thu, Sep 28, 2006 at 09:40:57PM -0400, Steven Rostedt wrote:> One thing that is missing though, in this patch, is the update to > ./debugger/pdb/evtchn.ml, which still has the hard coded 201 as theAs far as I can tell this is completely abandoned code, it has been unable to compile for a long time. Can''t we just remove the directory? The false positives get annoying after a while. regards john _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 29/9/06 2:40 am, "Steven Rostedt" <srostedt@redhat.com> wrote:> This patch makes evtchn use a dynamic minor number instead. It also > updates the code in tools to create the device node if udev fails. The > tools now read the sysfs system to find the minor number needed.Are there really systems out there that mount sysfs yet don''t use udev? It''d be nice to avoid the skanky search-and-create code in userspace. But we''ll take it if it really is likely to be useful. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Steven Rostedt
2006-Sep-29 12:08 UTC
[Xen-devel] Re: [PATCH] make evtchn use a dynamic minor
Keir Fraser wrote:> On 29/9/06 2:40 am, "Steven Rostedt" <srostedt@redhat.com> wrote: > >> This patch makes evtchn use a dynamic minor number instead. It also >> updates the code in tools to create the device node if udev fails. The >> tools now read the sysfs system to find the minor number needed. > > Are there really systems out there that mount sysfs yet don''t use udev?I use to :-) (and sometimes still do!)> > It''d be nice to avoid the skanky search-and-create code in userspace. But > we''ll take it if it really is likely to be useful. >Yeah, I didn''t care much for it either, but my intent was to make it as robust as possible. Either way is fine with me. -- Steve _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel