Hi, When I specified a directory to xm dump-core command, the directory was renamed. # mkdir /xen/dump # ll /xen/ drwxr-xr-x 2 root root 4096 Sep 19 21:04 dump # xm dump-core vm1 /xen/dump dumping core of domain:vm1 ... # ll /xen/ drwxr-xr-x 2 root root 4096 Sep 19 21:04 dump-incomplete This patch fixes this issue, and shows an error message. # xm dump-core vm1 /xen/dump dumping core of domain:vm1 ... Error: core dump failed: (21, ''Is a directory'') Signed-off-by: Masaki Kanno <kanno.masaki@jp.fujitsu.com> Best regards, Kan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Alastair Tse
2006-Sep-22 16:37 UTC
Re: [Xen-devel] [PATCH] Fix rename issue of xm dump-core
On Tue, 2006-09-19 at 21:37 +0900, Masaki Kanno wrote:> This patch fixes this issue, and shows an error message. > > # xm dump-core vm1 /xen/dump > dumping core of domain:vm1 ... > Error: core dump failed: (21, ''Is a directory'')Rather than handling the core dump failure for a directory with a special case, I''ve added a check before the dump to make sure the file name supplied is not a directory. Thanks, Alastair _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Masaki Kanno
2006-Sep-23 04:50 UTC
Re: [Xen-devel] [PATCH] Fix rename issue of xm dump-core
Hi Alastair, Thanks for your modification. I sent a bug fix patch one more about xm dump-core command. Could you apply it? http://lists.xensource.com/archives/html/xen-devel/2006-09/msg00532.html Best reagrds, Kan>On Tue, 2006-09-19 at 21:37 +0900, Masaki Kanno wrote: >> This patch fixes this issue, and shows an error message. >> >> # xm dump-core vm1 /xen/dump >> dumping core of domain:vm1 ... >> Error: core dump failed: (21, ''Is a directory'') > >Rather than handling the core dump failure for a directory with a >special case, I''ve added a check before the dump to make sure the file >name supplied is not a directory. > >Thanks, > >Alastair > > >_______________________________________________ >Xen-devel mailing list >Xen-devel@lists.xensource.com >http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Alastair Tse
2006-Sep-23 09:43 UTC
Re: [Xen-devel] [PATCH] Fix rename issue of xm dump-core
Yes, I think that patch makes a a lot of sense. There is an unnecessary getopt import and the exceptions need to be caught and reported appropriately. I''ll apply this patch shortly. Cheers, Alastair On 23 Sep 2006, at 05:50, Masaki Kanno wrote:> Hi Alastair, > > Thanks for your modification. > > I sent a bug fix patch one more about xm dump-core command. > Could you apply it? > > http://lists.xensource.com/archives/html/xen-devel/2006-09/ > msg00532.html > > Best reagrds, > Kan > >> On Tue, 2006-09-19 at 21:37 +0900, Masaki Kanno wrote: >>> This patch fixes this issue, and shows an error message. >>> >>> # xm dump-core vm1 /xen/dump >>> dumping core of domain:vm1 ... >>> Error: core dump failed: (21, ''Is a directory'') >> >> Rather than handling the core dump failure for a directory with a >> special case, I''ve added a check before the dump to make sure the >> file >> name supplied is not a directory. >> >> Thanks, >> >> Alastair >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel