Hi, to avoid lots of #ifdefs I would like to separate some code in kernel.c into another new file arch/x86/common.c and use a function like arch_init() to do some architecture special initializations. I added a patch with my suggestions for the changes. Please can anybody look at this and give some feedback! Thanks. Dietmar. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Hi, I try this patch for mini-os again in the hope of a answer. (see http://lists.xensource.com/archives/html/xen-devel/2006-09/msg00439.html) to avoid lots of #ifdefs in extras/mini-os/kernel.c I would like to separate some code in kernel.c into another new file arch/x86/common.c and use a function like arch_init() to do some architecture specific initializations. I added a patch with my suggestions for the changes. -- Dietmar Hahn Telephone: +49 (0) 89 636 40274 Fujitsu Siemens Computers Telefax: +49 (0) 89 636 40601 Otto-Hahn-Ring 6 Email: dietmar.hahn@fujitsu-siemens.com 81739 München, Germany Internet: http://www.fujitsu-siemens.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Am Freitag, 22. September 2006 10:40 schrieb Dietmar Hahn:> Hi, > > I try this patch for mini-os again in the hope of a answer. > (see > http://lists.xensource.com/archives/html/xen-devel/2006-09/msg00439.html) > > to avoid lots of #ifdefs in extras/mini-os/kernel.c I would like to > separate some code in kernel.c into another new file arch/x86/common.c and > use a function like arch_init() to do some architecture specific > initializations. I added a patch with my suggestions for the changes.Sorry, I pressed the send button to fast. Now is the patch attached. Thanks. Dietmar. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
> Hi, >Hi there. Sorry for a slow reply (I''ve been busy with other stuff over the last week). The patch looks ok to me, but I think a better filename would be "setup.c" not "common.c". The fact that the file is in arch/x86 makes it quite obvious that it''s common to all x86 subarchs. Could you resent the patch (directly to Keir maybe). Thanks Gregor> I try this patch for mini-os again in the hope of a answer. > (see http://lists.xensource.com/archives/html/xen-devel/2006-09/ > msg00439.html) > > to avoid lots of #ifdefs in extras/mini-os/kernel.c I would like > to separate > some code in kernel.c into another new file arch/x86/common.c and > use a > function like arch_init() to do some architecture specific > initializations. > I added a patch with my suggestions for the changes. > > > > -- > Dietmar Hahn Telephone: +49 (0) 89 636 40274 > Fujitsu Siemens Computers Telefax: +49 (0) 89 636 40601 > Otto-Hahn-Ring 6 Email: dietmar.hahn@fujitsu-siemens.com > 81739 München, Germany Internet: http://www.fujitsu-siemens.com_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Am Freitag, 22. September 2006 15:35 schrieben Sie:> > Hi, > > Hi there. > > Sorry for a slow reply (I''ve been busy with other stuff over the last > week). > > The patch looks ok to me, but I think a better filename would be > "setup.c" not "common.c". The fact that the file is in arch/x86 makes > it quite obvious that it''s common to all x86 subarchs. > > Could you resent the patch (directly to Keir maybe). > > Thanks > Gregor >Hi Keir, like Gregor said I changed the filename from common.c to setup.c. Attached is the new patch. Thanks. Dietmar. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel