KUWAMURA Shin''ya
2006-Sep-08 01:50 UTC
[Xen-devel] [PATCH] xenmon: --ms_per_sample: check too large value
Hi, This patch adds the argument check of "--ms_per_sample" option. If a value of "--ms_per_sample" option is larger than a value of "--time" option, xenmon may generate no log file. So, too large "--ms_per_sample" should be treated as an error. e.g. % xenmon.py --ms_per_sample=2000 -t 1 -n usage: xenmon.py [options] xenmon.py: error: option --ms_per_sample: too large (> 1000 ms) # Notice that a unit of "--time" is a second. Signed-off-by: KUWAMURA Shin''ya <kuwa@jp.fujitsu.com> Thanks, -- KUWAMURA Shin''ya _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
KUWAMURA Shin''ya
2006-Sep-19 04:57 UTC
Re: [Xen-devel] [PATCH] xenmon: --ms_per_sample: check too large value
Hi, Do you have any comment? If you have no comment, could you commit this patch? http://lists.xensource.com/archives/html/xen-devel/2006-09/msg00244.html On <20060908.105047.77000778.kuwa@jp.fujitsu.com>, "KUWAMURA Shin''ya" said:> > This patch adds the argument check of "--ms_per_sample" option. > > If a value of "--ms_per_sample" option is larger than a value of > "--time" option, xenmon may generate no log file. So, too large > "--ms_per_sample" should be treated as an error. > > e.g. > % xenmon.py --ms_per_sample=2000 -t 1 -n > usage: xenmon.py [options] > > xenmon.py: error: option --ms_per_sample: too large (> 1000 ms) > > # Notice that a unit of "--time" is a second. > > Signed-off-by: KUWAMURA Shin''ya <kuwa@jp.fujitsu.com>Best Regards, -- KUWAMURA Shin''ya _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel