Herbert Xu
2006-Sep-01 13:41 UTC
[Xen-devel] vm_map_xen_pages removal breaks modular oprofile
Hi Keir: It has been brought to my attention that modular oprofile is broken because it now calls get_vm_area which is not an exported function. This appears to be the result of the changeset that removed vm_map_xen_pages which was only used by oprofile. So we either need to export get_vm_area in Xen, or put that function back. What do you think about this? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Sep-01 14:49 UTC
[Xen-devel] Re: vm_map_xen_pages removal breaks modular oprofile
On 1/9/06 2:41 pm, "Herbert Xu" <herbert@gondor.apana.org.au> wrote:> It has been brought to my attention that modular oprofile is broken > because it now calls get_vm_area which is not an exported function. > > This appears to be the result of the changeset that removed > vm_map_xen_pages which was only used by oprofile. > > So we either need to export get_vm_area in Xen, or put that > function back. What do you think about this?Oops. It should use alloc_vm_area(), which we do export. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Herbert Xu
2006-Sep-02 02:18 UTC
[Xen-devel] Re: vm_map_xen_pages removal breaks modular oprofile
On Fri, Sep 01, 2006 at 03:49:39PM +0100, Keir Fraser wrote:> > Oops. It should use alloc_vm_area(), which we do export.Thanks for the quick response and fix! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel