Xen devel - Aug 2006 - [PATCH][vTPM] 3/3: TPM device model for qemu dm

This patch adds a TPM device model to the qemu dm for fully virtualized
VMs. It is enabled in the VM only if the user requests a TPM device in
the vm configuration file using the ''vtpm=[...]'' line. It
enables the
qemu device model command line with a ''vtpm_instance <instance
number>''
parameter.

Signed-off-by: David Safford <safford@watson.ibm.com>
Signed-off-by: Stefan Berger <stefanb@us.ibm.com>



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 8/21/06, Stefan Berger <stefanb@us.ibm.com>
wrote:
> This patch adds a TPM device model to the qemu dm for fully virtualized
> VMs. It is enabled in the VM only if the user requests a TPM device in
> the vm configuration file using the ''vtpm=[...]'' line. It
enables the
> qemu device model command line with a ''vtpm_instance <instance
number>''
> parameter.
Isn''t the vtpm instance stored in xenstore anyway?  If so, then please
add code to ioemu''s xenstore.c to read it from there instead of adding
a command line switch.  We''re moving away from command line switches
for device configuration.

Minor nitpicks:
- don''t use extern to access global variables, add them to vl.h
instead.
- add tpm.c to VL_OBJS on a separate line, makes merging it much easier.

    christian
>
> Signed-off-by: David Safford <safford@watson.ibm.com>
> Signed-off-by: Stefan Berger <stefanb@us.ibm.com>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>
>
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel