Xen devel - Aug 2006 - [PATCH] xentrace event mask for memory management class

Since TRC_MEM is defined as 0x000af000 in xen/include/public/trace.h,
TRC_MEM = TRC_SCHED | TRC_VMX.  I feel strange about this.  I do not
think scheduling is a part of memory management.  Am I right?

If not, please tell me the background TRC_MEM is defined as TRC_SCHED
| TRC_VMX.  If so, please apply this patch.

This patch defines TRC_MEM as an independent event mask.  In addition,
xentrace accepts ''-e mem'' option so that it puts memory
management
events in trace buffers.  The manual page (xentrace.8) is also
modified accordingly.

Tested by compiling on x86 and ia64, booting Dom0 and DomU, taking a
xentrace log with ''-e mem'' option.

Signed-off-by: Hiroya INAKOSHI <inakoshi.hiroya@jp.fujitsu.com>




_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

> Since TRC_MEM is defined as 0x000af000 in xen/include/public/trace.h,
> TRC_MEM = TRC_SCHED | TRC_VMX.  I feel strange about this.  I do not
> think scheduling is a part of memory management.  Am I right?
Looks to me like it''s probably a typo that hasn''t been spotted
before - well
done.
> This patch defines TRC_MEM as an independent event mask.  In addition,
> xentrace accepts ''-e mem'' option so that it puts memory
management
> events in trace buffers.  The manual page (xentrace.8) is also
> modified accordingly.
>
> Tested by compiling on x86 and ia64, booting Dom0 and DomU, taking a
> xentrace log with ''-e mem'' option.
Thanks for the thorough testing and for updating the man page!

The patch looks fine to me.

+1

Cheers,
Mark

-- 
Dave: Just a question. What use is a unicyle with no seat?  And no pedals!
Mark: To answer a question with a question: What use is a skateboard?
Dave: Skateboards have wheels.
Mark: My wheel has a wheel!

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Hi,

The patch for xentrace I posted has not been applied yet.  This patch is
just for correcting a typo, as Mark said, and is harmless.  Please
apply.  Thanks.

Hiroya.


INAKOSHI Hiroya wrote:
> Since TRC_MEM is defined as 0x000af000 in xen/include/public/trace.h,
> TRC_MEM = TRC_SCHED | TRC_VMX.  I feel strange about this.  I do not
> think scheduling is a part of memory management.  Am I right?
> 
> If not, please tell me the background TRC_MEM is defined as TRC_SCHED
> | TRC_VMX.  If so, please apply this patch.
> 
> This patch defines TRC_MEM as an independent event mask.  In addition,
> xentrace accepts ''-e mem'' option so that it puts memory
management
> events in trace buffers.  The manual page (xentrace.8) is also
> modified accordingly.
> 
> Tested by compiling on x86 and ia64, booting Dom0 and DomU, taking a
> xentrace log with ''-e mem'' option.
> 
> Signed-off-by: Hiroya INAKOSHI <inakoshi.hiroya@jp.fujitsu.com>
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
-- 
富士通株式会社　プラットフォーム技術開発本部　仮想システム開発統括部
稲越宏弥 <inakoshi.hiroya@jp.fujitsu.com>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel